Bug 718955

Summary: Review Request: spice-client - SPICE protocol client
Product: Red Hat Enterprise Linux 5 Reporter: Marc-Andre Lureau <marcandre.lureau>
Component: Package ReviewAssignee: Matthias Clasen <mclasen>
Status: CLOSED NOTABUG QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 5.0CC: mclasen, notting, pm-rhel
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-26 10:26:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 188273, 718810    

Description Marc-Andre Lureau 2011-07-05 10:28:50 UTC
Spec URL: http://elmarco.fedorapeople.org/SRPMS/el5/spice-client.spec
SRPM URL: http://elmarco.fedorapeople.org/SRPMS/el5/spice-client-0.8.1-2.src.rpm

Description:
This package contains the SPICE client application.

Comment 1 Matthias Clasen 2011-07-21 02:43:26 UTC
package builds fine locally

rpmlint output looks fine:

[mclasen@planemask ~]$ rpmlint ~/rpmbuild/RPMS/x86_64/spice-client-*
spice-client-client.x86_64: W: self-obsoletion qspice-client obsoletes qspice-client
spice-client-client.x86_64: W: no-manual-page-for-binary spicec
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 2 Matthias Clasen 2011-07-21 02:57:24 UTC
package name: ok
spec file name: ok
packaging guidelines: ok
  I guess the qspice-client obsoletes could be versioned, but that may not be
  that important in this case
license: ok
license tag: ok
license file: ok
spec language: ok
spec legibility: ok
upstream sources: ok
buildable: ok
excludearch: ok
buildrequires: ok
locale handling: ok
ldconfig: ok
system libs: ok
relocatable: ok
directory ownership: ok
duplicate files: ok
file permissions: ok
macro use: ok
permissible content: ok
%doc content: ok
large docs: ok
headers: ok
static libraries: ok
shared libs: ok
devel deps: ok
libtool archives: ok
gui apps: ok
duplicate ownership: ok
utf8 filenames: ok

package looks fine, approved

Comment 3 Marc-Andre Lureau 2011-07-26 10:26:41 UTC
thanks, closing