Bug 719067
| Summary: | Review Request: rubygem-hmac - This module provides common interface to HMAC functionality | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Lalancette <clalance> |
| Component: | Package Review | Assignee: | Mo Morsi <mmorsi> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mmorsi, notting, package-review |
| Target Milestone: | --- | Flags: | mmorsi:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-07-20 17:30:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 719073 | ||
|
Description
Chris Lalancette
2011-07-05 16:32:07 UTC
Taking this one Overall looks good, koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=3199493 A few specific nuances though: - please replace all the %defines at the top w/ %globals http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - please enable --ri documentaion on the gem install command - lib/hmac.rb is licensed under the ruby license and thus the package license must be set to MIT and Ruby accordingly - please mark the test directory as %doc - since the test directory is included, it wouldn't be a bad idea to include a %check section to run the suite - you need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby as instructed here http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Packaging_Guidelines (In reply to comment #2) > Overall looks good, koji build is green: > > http://koji.fedoraproject.org/koji/taskinfo?taskID=3199493 > > A few specific nuances though: > > - please replace all the %defines at the top w/ %globals > > http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define Oops, fixed. > > > - please enable --ri documentaion on the gem install command Done, but the use of --ri is very inconsistent in Fedora. Many packages don't have it, but some do. > > - lib/hmac.rb is licensed under the ruby license and thus the package license > must be set to MIT and Ruby accordingly Fixed. > > - please mark the test directory as %doc Fixed. > > - since the test directory is included, it wouldn't be a bad idea to include a > %check section to run the suite Fixed. > > - you need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby as instructed > here > > http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Packaging_Guidelines Done. New SRPM: http://people.redhat.com/clalance/rubygem-hmac/rubygem-hmac-0.4.0-2.fc14.src.rpm New SPEC: http://people.redhat.com/clalance/rubygem-hmac/rubygem-hmac.spec Looks good. APPROVED. New Package SCM Request ======================= Package Name: rubygem-hmac Short Description: This module provides common interface to HMAC functionality Owners: clalance mmorsi Git done (by process-git-requests). |