Bug 719069

Summary: clean up compiler warnings in 389-ds-base 1.2.9
Product: [Community] 389 Reporter: Noriko Hosoi <nhosoi>
Component: Directory ServerAssignee: Noriko Hosoi <nhosoi>
Status: CLOSED CURRENTRELEASE QA Contact: Viktor Ashirov <vashirov>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.2.9CC: amsharma, jgalipea, rmeggins
Target Milestone: ---Keywords: VerifiedUpstream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-07 11:38:52 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 708096    
Attachments:
Description Flags
git patch file (master) nkinder: review+

Description Noriko Hosoi 2011-07-05 12:39:47 EDT
Description of problem:
dap/servers/slapd/entry.c:528: warning: passing argument 2 of '_entry_set_tombstone_rdn' discards qualifiers from pointer target type
ldap/servers/slapd/entry.c:1240: warning: passing argument 2 of '_entry_set_tombstone_rdn' discards qualifiers from pointer target type
ldap/servers/slapd/mapping_tree.c:1003: warning: 'mapping_tree_node_validate' defined but not used
ldap/servers/plugins/automember/automember.c:1709: warning: label 'bail' defined but not used
ldap/servers/plugins/automember/automember.c:1692: warning: unused variable 'smods'
ldap/servers/plugins/automember/automember.c:1752: warning: implicit declaration of function 'slapi_entry_attr_hasvalue'
ldap/servers/plugins/mep/mep.c:2108: warning: implicit declaration of function 'slapi_entry_attr_hasvalue'
ldap/servers/plugins/replication/windows_protocol_util.c:2169: warning: passing argument 2 of 'slapi_entry_apply_mod' discards qualifiers from pointer target type
Comment 1 Noriko Hosoi 2011-07-05 12:54:58 EDT
Created attachment 511349 [details]
git patch file (master)

Description:
slapd/entry.c
  -- added const qualifier to the 2nd arg of _entry_set_tombstone_rdn.
slapd/mapping_tree.c
  -- commented out mapping_tree_node_validate.
plugins/automember/automember.c
  -- removed a unused variable smods.
  -- modified to use label "bail".
  -- replaced deprecated slapi_entry_attr_hasvalue with
     slapi_entry_attr_has_syntax_value.
plugins/mep/mep.c
  -- replaced deprecated slapi_entry_attr_hasvalue with
     slapi_entry_attr_has_syntax_value.
Comment 2 Noriko Hosoi 2011-07-05 13:40:28 EDT
Reviewed by Nathan (Thank you!!!)

Pushed to master.

$ git merge work
Updating f069f4b..dfcc435
Fast-forward
 ldap/servers/plugins/automember/automember.c       |   14 +++++++----
 ldap/servers/plugins/mep/mep.c                     |   24 ++++++++++++-------
 .../plugins/replication/windows_protocol_util.c    |    2 +-
 ldap/servers/slapd/entry.c                         |    4 +-
 ldap/servers/slapd/mapping_tree.c                  |    3 ++
 5 files changed, 30 insertions(+), 17 deletions(-)

$ git push
Counting objects: 27, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (14/14), done.
Writing objects: 100% (14/14), 1.79 KiB, done.
Total 14 (delta 10), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
   f069f4b..dfcc435  master -> master