Bug 719282

Summary:	VM state .save file should be $UUID.save and not $VMNAME.save.
Product:	Red Hat Enterprise Linux 6	Reporter:	Dan Yasny <dyasny>
Component:	libvirt	Assignee:	Osier Yang <jyang>
Status:	CLOSED WONTFIX	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.1	CC:	acathrow, dallan, dyuan, mzhan, rwu
Target Milestone:	rc
Target Release:	6.2
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-07-12 12:42:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Yasny 2011-07-06 10:45:55 UTC

Description of problem:
vm names might be recycled, unlike the UUIDs, and in some cases, an existing .save file for $VMNAME would not belong to a new VM with the same name, causing the new VM not to be able to start

Version-Release number of selected component (if applicable):
libvirt-0.8.7-18.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1.create a VM
2.start it up and then in virt-manager go to virtual machine>shut down>save
3.when the VM goes down, delete it
4.create a new VM with the same name
5. try to run the VM
  
Actual results:
VM fails to run because the save file belongs to another VMs UUID

Expected results:
.save should be deleted when the related VM is deleted (I'll open another BZ for this)

if the filename for the .save file was $VMUUID.save then it would not be picked up for the new VM, and would not cause a new clean VM to fail to start up

Additional info:

Comment 1 Dan Yasny 2011-07-06 10:49:57 UTC

BZ#719284 opened for the .save file not being deleted

Comment 4 Osier Yang 2011-07-12 12:42:40 UTC

I close the bug as WONTFIX for above reason.

Comment 5 Dave Allan 2011-07-13 00:43:37 UTC

What Osier is saying is that the right way to fix this is to fix the other BZ you filed so that the vmsave file is properly deleted when the VM is undefined.  If the vmsave files are properly removed, then we will never get into this state.  Since the vmsave files are more user friendly when named by the VM name, we should go that route.