Bug 719456
| Summary: | Review Request: edg-gridftp-client - Command line clients to GridFTP libraries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Traylen <steve.traylen> |
| Component: | Package Review | Assignee: | Mattias Ellert <mattias.ellert> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mattias.ellert, notting, package-review |
| Target Milestone: | --- | Flags: | steve.traylen:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | edg-gridftp-client-1.2.9.2-2.el4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-28 05:39:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Steve Traylen
2011-07-06 22:42:22 UTC
Fedora review edg-gridftp-client 2011-08-18 + rpmlint output: edg-gridftp-client.x86_64: W: spelling-error %description -l en_US mkdir -> mk dir, mk-dir, midiron edg-gridftp-client.x86_64: W: spelling-error %description -l en_US rmdir -> rm dir, rm-dir, midiron edg-gridftp-client.src: W: spelling-error %description -l en_US mkdir -> mk dir, mk-dir, midiron edg-gridftp-client.src: W: spelling-error %description -l en_US rmdir -> rm dir, rm-dir, midiron edg-gridftp-client.src: W: invalid-url Source0: edg-gridftp-client-1.2.9.2.tar.gz 3 packages and 0 specfiles checked; 0 errors, 5 warnings. These warnings can be ignored. + The package is named according to the guidelines + The specfile is named after the package + The package's License tag (EU Datagrid) is a Fedora approved license + The License tag matches the actual license statements in the sources + Package installs LICENSE file as %doc + Specfile is written in legible English + Source matches upstream (ignoring CVS directories) diff -ur --exclude CVS checkout/edg-gridftp-client-1.2.9.2 edg-gridftp-client-1.2.9.2 (no output) + The package builds in mock (F15 x96_64) + BuildRequires are sane + no locales + no shared libraries + no bundled sources + no created directories + no duplicate %files Comment: The manpages are normally listed as xxx.1* and not xxx.1.* in the %files section in order to also allow non-compressed files. + File permissions are sane + Macros are used consistently + Package contains code + No large documentation files + %doc is not runtime essential + no headers + no static libraries + no sub-packages + no libtool archives + no GUIs + Package does not own other's directories + Filenames are UTF8 Apart from the comment about the manpages in %files there are no issues. Package approved. New Package SCM Request ======================= Package Name: edg-gridftp-client Short Description: Command line clients to GridFTP libraries Owners: stevetraylen Branches: f15 f16 el4 el5 el6 InitialCC Thanks for the review, I'll glob the man page endings before import. Steve. Mattias, I switched the wrong flag, could your reassign the flag. Steve Git done (by process-git-requests). Edited request for syntax, let me know if something isn't as expected. edg-gridftp-client-1.2.9.2-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/edg-gridftp-client-1.2.9.2-2.el5 edg-gridftp-client-1.2.9.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/edg-gridftp-client-1.2.9.2-2.fc15 edg-gridftp-client-1.2.9.2-2.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/edg-gridftp-client-1.2.9.2-2.el4 edg-gridftp-client-1.2.9.2-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/edg-gridftp-client-1.2.9.2-2.fc16 edg-gridftp-client-1.2.9.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/edg-gridftp-client-1.2.9.2-2.el6 edg-gridftp-client-1.2.9.2-2.fc16 has been pushed to the Fedora 16 testing repository. edg-gridftp-client-1.2.9.2-2.fc16 has been pushed to the Fedora 16 stable repository. edg-gridftp-client-1.2.9.2-2.fc15 has been pushed to the Fedora 15 stable repository. edg-gridftp-client-1.2.9.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository. edg-gridftp-client-1.2.9.2-2.el5 has been pushed to the Fedora EPEL 5 stable repository. edg-gridftp-client-1.2.9.2-2.el4 has been pushed to the Fedora EPEL 4 stable repository. |