Bug 719920

Summary: [tito_build] On clean F14 katello rpm build fails
Product: Red Hat Satellite Reporter: Garik Khachikyan <gkhachik>
Component: InfrastructureAssignee: Lukas Zapletal <lzap>
Status: CLOSED CURRENTRELEASE QA Contact: Garik Khachikyan <gkhachik>
Severity: high Docs Contact:
Priority: high    
Version: 6.0.0CC: lzap, mkoci
Target Milestone: Unspecified   
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-22 17:48:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 747354    
Attachments:
Description Flags
katello tito build log none

Description Garik Khachikyan 2011-07-08 12:26:18 UTC
Created attachment 511929 [details]
katello tito build log

Description of problem:
Using recent katello git sources to build katello-*.rpm on fresh and "minimal" installed F14-x86_64 fails (full log is attached)
---
########## ERROR ############
Error running command: LC_ALL=C rpmbuild --define "_source_filedigest_algorithm md5"  --define "_binary_filedigest_algorithm md5"  --define "_sourcedir /tmp/tito/katello/rpmbuild-katello-fbecbc1747b0547caa51923238072d6b0e539e1e/SOURCES" --define "_builddir /tmp/tito/katello/rpmbuild-katello-fbecbc1747b0547caa51923238072d6b0e539e1e/BUILD" --define "_srcrpmdir /tmp/tito/katello" --define "_rpmdir /tmp/tito/katello"   --clean -ba /tmp/tito/katello/rpmbuild-katello-fbecbc1747b0547caa51923238072d6b0e539e1e/SOURCES/katello-git-325.fbecbc1/katello.spec
Status code: 256
---

And actually this is due to 2 errors running "Checking HAML syntax" ...
---
1.
haml -c ./app/views/common/_one_panel.html.haml 
Haml error on line 10: Invalid filter name ":panel_id => panel_id, :hover_text => (send(hover_text_cb, item) if hover_text_cb)}".
2.
haml -c ./app/views/sync_schedules/index.html.haml 
Haml error on line 16: Invalid filter name ":controller => "sync_schedules"}, :method => :post, :class => 'dialogbutton fr', :id => 'apply_button'".
---

For both cases git blames lzap there (sorry Lukas :))

Version-Release number of selected component (if applicable):
current git master

How reproducible:
always running tito build --rpm --test on fresh installed F14-x86_64

Steps to Reproduce:
1.Provision fresh F14 x86_64 with minimal packages
2.do yum install tito git -y
3.git clone <katello.git>
4.cd katello/src/
5.tito build --test --rpm --output /tmp/tito/katello/
6. Follow the output (better to redirect the tito output to a file - above)  

Actual results:
Failure described above. no rpm-s prepared.

Expected results:
No failure , rpm should be built.

Additional info:
Attached is the full log of the process (and more)

Comment 1 Garik Khachikyan 2011-07-08 12:27:05 UTC
take priorities up - would be better to have them fixed asap. thanks.

Comment 2 Lukas Zapletal 2011-07-08 12:33:49 UTC
I will move the checks into the Jerkins job.

Comment 3 Garik Khachikyan 2011-07-08 12:38:57 UTC
just noticed:
by default rubygem-haml-2.2.24-1.fc14.noarch gets installed (as build
dependency) when the server does not have the katello repo enabled / setup .

Having rubygem-haml-3.0.25-2.fc14.noarch (from fedora-katello.repo) fixes the
"issue".

Comment 4 Lukas Zapletal 2011-07-08 15:48:43 UTC
8cda5e4 spec - moving syntax checks to external script (CI)

Comment 5 Garik Khachikyan 2011-09-14 11:29:15 UTC
Fixed.

No issues on tito-building F14 Katello there.

thanks for the fix.