| Summary: | Review Request: perl-Net-FTP-RetrHandle - Provides a file reading interface for reading files on a remote FTP server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bernard Johnson <bjohnson> |
| Component: | Package Review | Assignee: | Richard Shaw <hobbes1069> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hobbes1069, notting, package-review |
| Target Milestone: | --- | Flags: | hobbes1069:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Net-FTP-RetrHandle-0.2-3.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-02 02:03:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 627373 | ||
|
Description
Bernard Johnson
2011-07-09 04:42:09 UTC
Spec URL: http://fedorapeople.org/~bjohnson/perl-Net-FTP-RetrHandle.spec SRPM URL: http://fedorapeople.org/~bjohnson/perl-Net-FTP-RetrHandle-0.2-2.fc14.src.rpm * Sun Jul 17 2011 Bernard Johnson <bjohnson> - 0.2-2 - add additional documentation files including test cases Confirmed. SRPM rpmlint perl-Net-FTP-RetrHandle-0.2-2.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. SPEC rpmlint perl-Net-FTP-RetrHandle.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. I'm a new reviewer, so if these comments are mis-placed please bear with me. The %defattr(-,root,root,-) section could be removed. This is now default so will be ignored. (See Packaging Guidelines, section File Permissions) I was unable to find the Licence files in Net-FTP-RetrHandle-0.2.tar.gz Regards Damian (In reply to comment #2) > The %defattr(-,root,root,-) section could be removed. This is now default so > will be ignored. (See Packaging Guidelines, section File Permissions) The intention is to push this package back as far as RHEL 4 which only has RPM 4.3.x. I'd like it to still build correctly on any platform version that it's pushed to. > I was unable to find the Licence files in Net-FTP-RetrHandle-0.2.tar.gz There is no individual license file. The license is in lib/Net/FTP/RetrHandle.pm under "Copyright". I'll take this one too. Minor observations: 1. Got a redundant %doc in this one too. 2. Isn't an underscore in front of a macro usually a path by convention? (i.e. _libdir, _sharedir, _includedir, etc.) Thanks, Richard Since neither of the above are showstoppers: +: OK -: must be fixed =: should be fixed (at your discretion) ?: Question or clairification needed N: not applicable MUST: [+] rpmlint output: shown in comment: No warnings or errors. [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license: GPL+ or Artistic [+] license field matches the actual license. [N] license file is included in %doc [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sums match (0e25887641efe59b6fd2dd6964fb77a7) [+] package builds on at least one primary arch: Tested F14 [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [N] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [N] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [N] header files in -devel [N] static libraries in -static [N] .so in -devel [N] -devel requires main package [+] package contains no libtool archives [N] package contains a desktop file, uses desktop-file-install/validate [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [N] query upstream for license text [N] description and summary contains available translations [+] package builds in mock [+] package builds on all supported arches [?] package functions as described: Provides requirement for BackupPC [+] sane scriptlets [N] subpackages require the main package [N] placement of pkgconfig files [N] file dependencies versus package dependencies [N] package contains man pages for binaries/scripts *** APPROVED *** (In reply to comment #5) > Minor observations: > > 1. Got a redundant %doc in this one too. Yeah, I already fixed it locally and it will be fixed in the initial package. > 2. Isn't an underscore in front of a macro usually a path by convention? (i.e. > _libdir, _sharedir, _includedir, etc.) Well, that's a good observation and I've never thought about it too much so I checked the output of 'rpm --showrc'. For the vast majority of cases it is a path or program. But that's not only what it's used for (check _c_flags, _arch, etc). In my case, having a software background, I used it to mean "internal", "private" or "only applies here". I don't feel strongly about it one way or the other... it's just a variable to make life easier :) New Package SCM Request ======================= Package Name: perl-Net-FTP-RetrHandle Short Description: Provides a file reading interface for reading files on a remote FTP server Owners: bjohnson Branches: f14, f15, el5, el6 InitialCC: perl-sig Git done (by process-git-requests). perl-Net-FTP-RetrHandle-0.2-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Net-FTP-RetrHandle-0.2-3.el6 perl-Net-FTP-RetrHandle-0.2-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Net-FTP-RetrHandle-0.2-3.fc14 perl-Net-FTP-RetrHandle-0.2-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Net-FTP-RetrHandle-0.2-3.fc15 perl-Net-FTP-RetrHandle-0.2-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Net-FTP-RetrHandle-0.2-3.el5 perl-Net-FTP-RetrHandle-0.2-3.el5 has been pushed to the Fedora EPEL 5 testing repository. perl-Net-FTP-RetrHandle-0.2-3.fc15 has been pushed to the Fedora 15 stable repository. perl-Net-FTP-RetrHandle-0.2-3.fc14 has been pushed to the Fedora 14 stable repository. perl-Net-FTP-RetrHandle-0.2-3.el5 has been pushed to the Fedora EPEL 5 stable repository. perl-Net-FTP-RetrHandle-0.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository. Package Change Request ====================== Package Name: perl-Net-FTP-RetrHandle New Branches: epel7 Owners: bjohnson InitialCC: perl-sig Git done (by process-git-requests). |