Bug 720140
Summary: | Modify FindDCMTK.cmake to enable us to use the fedora DCMTK package | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> | ||||||
Component: | cmake | Assignee: | Orion Poplawski <orion> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | high | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | rawhide | CC: | jreznik, orion, pertusus, rdieter | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | cmake-2.8.5-3.fc16 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2011-08-28 05:24:20 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 726201 | ||||||||
Attachments: |
|
Could you please file a bug upstream: http://public.kitware.com/Bug/my_view_page.php ? Thanks. I'm building cmake-2.8.5-2.fc16 in rawhide. Can you test that please when it finishes? Created attachment 515581 [details] updated patch Hi Orion, I'm afraid the previous patch wasn't enough. I've dug in and created this new patch. I've built it in koji here: http://koji.fedoraproject.org/koji/taskinfo?taskID=3234378 I've successfully built a package that needed dcmtk using the updated rpm with this patch :) I've found a few bugs related to cmake on the dcmtk site. I'm going through them and will submit this patch upstream also. If there's something wrong with it, they'll know how to fix it :D Thanks for looking into this. Ankur Ankur - As I understand it, cmake automatically replaces "lib" with "lib64" as needed. Could you try out a version without the /usr/lib64/... path and check? (In reply to comment #4) > Ankur - > > As I understand it, cmake automatically replaces "lib" with "lib64" as > needed. Could you try out a version without the /usr/lib64/... path and check? Hey Orion, I was trying to this when I realized I wouldn't be able to. I need to test this for x86_64. I only have a mock i386 rawhide configuration, and I can't run chain builds on koji for cmake and Ginkgo-CADx(uses dcmtk). Could you please try this out? Sorry :/ The gingko-cadx srpm is here: http://ankursinha.fedorapeople.org/ginkgocadx/Ginkgo-CADx-2.5.2.0-1.fc15.src.rpm Regards, Ankur I went ahead and fired off a build with the lib64 line removed: http://koji.fedoraproject.org/koji/taskinfo?taskID=3236551 When that is ready you can try a gingko-cadx rebuild. cmake-2.8.5-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/cmake-2.8.5-3.fc16 Package cmake-2.8.5-3.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing cmake-2.8.5-3.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/cmake-2.8.5-3.fc16 then log in and leave karma (feedback). cmake-2.8.5-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 512061 [details] patch to add path to FindDCMTK.cmake Description of problem: The current FindDCMTK.cmake file does not include the %{_libdir}/dcmtk path. Therefore, projects needing DCMTK fail to find DCMTK. Attached is a patch that the DCMTK maintainer sent me. However, it needs to include %{_libdir}/dcmtk/ instead of "lib" or "lib64". I don't know how to do this though. Can you please push a small update so we could build packages. It'll be needed in rawhide, f15 and f14.