Bug 720210

Summary: Provide native systemd unit file for lighttpd
Product: [Fedora] Fedora Reporter: Jóhann B. Guðmundsson <johannbg>
Component: lighttpdAssignee: Matthias Saou <matthias>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: gwync, hhorak, matthias, michael.tremer, ondrejj
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 1.4.28-3.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-04-17 15:45:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 713562    
Attachments:
Description Flags
Native systemd service file for lighttpd none

Description Jóhann B. Guðmundsson 2011-07-11 00:06:22 UTC 
Description of problem:

https://fedoraproject.org/wiki/Features/SysVtoSystemd

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Jóhann B. Guðmundsson 2011-07-11 00:08:16 UTC 
Created attachment 512120 [details]
Native systemd service file for lighttpd

https://fedoraproject.org/wiki/Packaging:Guidelines:Systemd
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
https://fedoraproject.org/wiki/Packaging:Tmpfiles.d
Comment 2 Matthias Saou 2011-07-11 18:48:38 UTC 
Pushed to Rawhide, though untested yet until I have a systemd enabled machine available.
Comment 3 Honza Horak 2011-10-24 11:17:32 UTC 
lighttpd doesn't start every-time with new systemd (systemd-35-1.fc16 and systemd-37-2.fc16 tested on F16 in VM, although it works on systemd-26-9 on F15). It seems like it starts correctly only the first time after system daemon is reload, so it is a race condition.

It seems to me like the PID file is not created fast enough, because systemd reports: "Failed to read PID file /var/run/lighttpd.pid after start. The service might be broken." If I run the daemon manually, the PID file is created right.

I'm proposing an easy patch that fixes the failure for me -- just don't demonize the daemon:
--- a/lighttpd.service
+++ b/lighttpd.service
@@ -3,10 +3,9 @@ Description=Lightning Fast Webserver With Light System Requirements
 After=syslog.target network.target
 
 [Service]
-Type=forking
 PIDFile=/var/run/lighttpd.pid
 EnvironmentFile=-/etc/sysconfig/lighttpd
-ExecStart=/usr/sbin/lighttpd -f /etc/lighttpd/lighttpd.conf
+ExecStart=/usr/sbin/lighttpd -D -f /etc/lighttpd/lighttpd.conf
 
 [Install]
 WantedBy=multi-user.target
Comment 4 Jan ONDREJ 2011-11-18 13:28:10 UTC 
Same problem here. Honza's patch work for me.
Comment 5 Michael Tremer 2011-11-27 16:11:22 UTC 
+1 for the change from Honza.
Comment 6 Gwyn Ciesla 2012-02-13 19:58:01 UTC 
Mattias, any objection to my committing Honza's changes?
Comment 7 Gwyn Ciesla 2012-03-14 16:24:45 UTC 
Ping?
Comment 8 Gwyn Ciesla 2012-04-17 15:45:18 UTC 
Done.
Comment 9 Matthias Saou 2012-04-18 13:19:43 UTC 
Sorry for missing this. Thanks Jon for fixing this.
Comment 10 Gwyn Ciesla 2012-04-18 13:25:20 UTC 
No worries, anytime.  If you have any other packages needing this you'd like me to do, email me.