Bug 720356

Summary: Review Request: rubygem-rack-ssl - Force SSL/TLS in your app
Product: [Fedora] Fedora Reporter: Vít Ondruch <vondruch>
Component: Package ReviewAssignee: Bohuslav "Slavek" Kabrda <bkabrda>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bkabrda, notting, package-review
Target Milestone: ---Flags: bkabrda: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-17 13:19:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vít Ondruch 2011-07-11 13:54:03 UTC 
Spec URL: http://people.redhat.com/vondruch/rubygem-rack-ssl.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-rack-ssl-1.3.2-1.fc16.src.rpm
Description: Rack middleware to force SSL/TLS.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3190854
Comment 1 Bohuslav "Slavek" Kabrda 2011-10-14 08:24:06 UTC 
I'm taking this one.
Comment 2 Bohuslav "Slavek" Kabrda 2011-10-14 08:35:18 UTC 
- License should be MIT, I don't see any references to GPLv2+ or Ruby in any of the included files.
- Maybe you could alter the way you run tests by moving the -I%{buildroot}%{geminstdir}/lib parameter to RUBYOPT. I think that once you use RUBYOPT, you should place everything in it not to make mess of things.

So after you correct the License tag, this package is APPROVED.
Comment 3 Vít Ondruch 2011-10-17 12:45:41 UTC 
(In reply to comment #2)
> - License should be MIT, I don't see any references to GPLv2+ or Ruby in any of
> the included files.

Good spot! Thank you.

> - Maybe you could alter the way you run tests by moving the
> -I%{buildroot}%{geminstdir}/lib parameter to RUBYOPT. I think that once you use
> RUBYOPT, you should place everything in it not to make mess of things.

It does make sense. I'll think about it :)

> So after you correct the License tag, this package is APPROVED.


Thank you for your review.



New Package SCM Request
=======================
Package Name: rubygem-rack-ssl
Short Description: Force SSL/TLS in your app
Owners: vondruch
Branches: 
InitialCC:
Comment 4 Gwyn Ciesla 2011-10-17 12:49:43 UTC 
Git done (by process-git-requests).