Bug 720447

Summary:	Review Request: python-unidecode - US-ASCII transliterations of Unicode text
Product:	[Fedora] Fedora	Reporter:	pjp <pj.pandit>
Component:	Package Review	Assignee:	Rahul Sundaram <metherid>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	metherid, notting, package-review, ville.skytta
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	metherid: fedora-review+ gwync: fedora-cvs+
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-07-18 04:45:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	496968

Description pjp 2011-07-11 16:27:52 UTC

Spec URL: http://pjp.dgplug.org/tools/python-unidecode.spec
SRPM URL: http://pjp.dgplug.org/tools/python-unidecode-0.04.7-1.fc14.src.rpm

Description: <description here>
It often happens that you have non-Roman text data in Unicode, but you
can't display it -- usually because you're trying to show it to a user via
an application that doesn't support Unicode, or because the fonts you need
aren't accessible. You could represent the Unicode characters as "???????"
or " BA A0q0...", but that's nearly useless to the user who actually wants
to read what the text says.

What Unidecode provides is a function, 'unidecode(...)' that takes Unicode
data and tries to represent it in ASCII characters (i.e., the universally
displayable characters between 0x00 and 0x7F). The representation is almost
always an attempt at transliteration -- i.e., conveying, in Roman letters,
the pronunciation expressed by the text in some other writing system.

For example 'unidecode(u"u5317u4EB0")' returns 'Bei Jing'.

This is a Python port of Text::Unidecode Perl module by
Sean M. Burke.

Comment 1 Rahul Sundaram 2011-07-12 00:09:36 UTC

Run a mock build or koji scratch build.  In particular, you need

BuildRequires:  python-devel
BuildRequires:  python-setuptools

Remove any commented out lines.   

Use name and version macro for Source0

Contact upstream and ask them to include a copy of the licenses.  Especially GPL requires this.  Include any licenses in %doc

Description can be shortened to:

This is a python port of Text::Unidecode Perl module.  It provides a function, 'unidecode(...)' that takes unicode data and tries to represent it in ASCII characters.  For example, 'unidecode(u"u5317u4EB0")' returns 'Bei Jing'.

%defattr(-,root,root,-) is redundant.  You don't need this anymore.  

Might consider moving %doc to be right after %files.

Comment 2 pjp 2011-07-12 17:32:42 UTC

I've made the changes. Please see the files below:

SPEC: http://pjp.dgplug.org/tools/python-unidecode.spec
SRPM: http://pjp.dgplug.org/tools/python-unidecode-0.04.7-2.fc14.src.rpm

Thank you.

Comment 3 Rahul Sundaram 2011-07-12 21:45:54 UTC

Use srcname and version macro in

Source0:	http://pypi.python.org/packages/source/U/Unidecode/Unidecode-0.04.7.tar.gz

Change URL to http://pypi.python.org/pypi/%{srcname}/

Redundant "is" in second statement in description. Drop that.  Upstream should include a copy of the license(s) and then I can approve this.

Comment 4 pjp 2011-07-15 14:50:19 UTC

I've made the changes. Please see:

SPEC: http://pjp.dgplug.org/tools/python-unidecode.spec
SRPM: http://pjp.dgplug.org/tools/python-unidecode-0.04.7-3.fc14.src.rpm

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3201515

Thank you.

Comment 5 Rahul Sundaram 2011-07-15 14:55:45 UTC

Looks good.  Make sure you branch for EPEL 6

====   APPROVED ====

Comment 6 pjp 2011-07-15 18:28:30 UTC

New Package SCM Request
=======================
Package Name: unidecode
Short Description: Python module for US-ASCII transliterations of Unicode text.
Owners: pjp
Branches: f14 f15 fl6 epel-6

Comment 7 Gwyn Ciesla 2011-07-15 18:37:38 UTC

Is this to be python-unidecode or unidecode?  Also, remove fl6 and replace
epel-6 with EL-6.

Comment 8 Rahul Sundaram 2011-07-16 01:37:01 UTC

New Package SCM Request
=======================
Package Name: python-unidecode
Short Description: Python module for US-ASCII transliterations of Unicode text.
Owners: pjp sundaram
Branches: f15 el-6

Comment 9 Gwyn Ciesla 2011-07-16 02:15:58 UTC

Git done (by process-git-requests).

Comment 10 Ville Skyttä 2011-07-17 20:57:59 UTC

Is there a reason this package is not noarch?  It doesn't seem to contain anything arch specific.

Comment 11 Rahul Sundaram 2011-07-18 04:45:44 UTC

Fixed.  Credited in changelog