Bug 720465

Description of problem:

When registering, unregistering, and (likely) binding, entitlement, product, and identity certificates are re-read many times over, and the GUI is refreshed repeatedly.

Version-Release number of selected component (if applicable):

subscription-manager-0.96.3-1

How reproducible:

Very.

Steps to Reproduce:
1. tail -f /var/log/rhsm/rhsm.log
2. Unregister from a server.
  
Actual results:

In the rhsm.log output you will see *multiple* instances of: 

2011-07-11 14:27:03,042 [DEBUG]  @certlib.py:675 - Sorting product and entitlement cert status for: 2011-07-11 14:27:03.042224
2011-07-11 14:27:03,043 [DEBUG]  @certlib.py:693 - Installed product IDs: ['37060']
2011-07-11 14:27:03,044 [DEBUG]  @certlib.py:684 - valid entitled products: []
2011-07-11 14:27:03,044 [DEBUG]  @certlib.py:685 - expired entitled products: []


Expected results:

This should happen just once, or at least as little as possible.

Additional info:

These appear to all be triggering via the managergui.py MainWindow.refresh method.

I believe this is related to the Backend classes file monitors. We monitor directories, I suspect the monitors are triggering once per file change. i.e. if we unregister, the identity cert, key, and their directory all get deleted, suspect this is triggering 3x refreshes right here.

Secondly, the file monitors catch changes that are also dealt with explicitly in the code. For example, managergui.py _on_unregister_prompt_response method calls refresh explicitly, but the unregistration is also caught by the identity certificate file monitor. The same goes for registration refresh.

I suspect if you have a number of entitlement certificates and unregister, you'll get additional GUI refreshes if you unregister and they all get removed.

Marked as low priority because, while this is messy and strange, the UI still seems acceptably responsive. It should get fixed eventually however.

Proposed fix:

If possible, we should get the file monitors to only trigger once, perhaps monitoring the identity cert itself instead of the directory it lives in. 

Secondly we should examine calls to refresh() in managergui, and eliminate those that are duplicated by the monitors for identity and entitlement certificates. (let the file monitors trigger the refreshes)