Bug 720783

Summary:	dupe comment detection.
Product:	[Fedora] Fedora	Reporter:	Dave Jones <davej>
Component:	abrt	Assignee:	Nikola Pajkovsky <npajkovs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	15	CC:	anton, dhoward, dvlasenk, iprikryl, jmoskovc, kklic, mtoman, npajkovs, pfrields
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-03-19 17:09:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	744774

Description Dave Jones 2011-07-12 18:21:45 UTC

Take a look at bug 713687.  Comments 8 through 14 are identical.
Either..

a) abrt should cache comments it made, and refuse to file already-filed comments.

or

b) abrt should check if the comment it is about to make has already been made, and refuse to do so if it's already in the bug. (Note this will require parsing all comments in case someone else files a new comment between two successive attempts by abrt).

Comment 1 Nikola Pajkovsky 2012-03-19 11:10:28 UTC

(In reply to comment #0)
> Take a look at bug 713687.  Comments 8 through 14 are identical.
> Either..
> 
> a) abrt should cache comments it made, and refuse to file already-filed
> comments.

we are not doing this

> or
> 
> b) abrt should check if the comment it is about to make has already been made,
> and refuse to do so if it's already in the bug. (Note this will require parsing
> all comments in case someone else files a new comment between two successive
> attempts by abrt).

we do this. Could you confirm that it works?

commit 9786e890de57260d2975a605512147779383c137
Author: Nikola Pajkovsky <npajkovs>
Date:   Thu Dec 1 14:48:48 2011 +0100

    do not insert duplicate comment to bugzilla
    
    Signed-off-by: Nikola Pajkovsky <npajkovs>

Comment 2 Dave Jones 2012-03-19 15:04:51 UTC

I don't recall having seen it happen recently.

Comment 3 Nikola Pajkovsky 2012-03-19 17:09:41 UTC

super, reopen when you find some suspicious pieces