Bug 720989

Summary:	Review Request: python-setuptools_hg - Setuptools plugin for finding files under Mercurial version control
Product:	[Fedora] Fedora	Reporter:	Praveen Kumar <kumarpraveen.nitdgp>
Component:	Package Review	Assignee:	Rahul Sundaram <metherid>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	james.hogarth, metherid, package-review
Target Milestone:	---	Flags:	metherid: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-04 02:45:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Praveen Kumar 2011-07-13 13:21:06 UTC

Spec URL: http://kumarpraveen.fedorapeople.org/setuptools-hg/python-setuptools_hg.spec
SRPM URL: http://kumarpraveen.fedorapeople.org/setuptools-hg/python-setuptools_hg-0.2.1-1.fc15.src.rpm
Description: setuptools_hg is a plugin for setuptools that enables setuptools to find files under the Mercurial version control system.
It uses the Mercurial Python library by default and falls back to use the
command line program ``hg``. That's especially useful inside virtualenvs
that don't have access to the system wide installed Mercurial lib (e.g. when
created with ``--no-site-packages``).

koji build 
http://koji.fedoraproject.org/koji/taskinfo?taskID=3196523

Comment 1 Rahul Sundaram 2011-07-14 01:43:19 UTC

Summary should not be more than 80 characters

Make the description a single para

Remove the comment:  # For noarch packages: sitelib

Change the build requires from python-distribute to python-setuptools.  Details at https://bugzilla.redhat.com/show_bug.cgi?id=606019

Move %doc to be after %files and add the license to it

Comment 2 Praveen Kumar 2011-07-14 03:52:00 UTC

Thanks for pointing out those mistakes.
Updated Spec url : http://kumarpraveen.fedorapeople.org/setuptools-hg/python-setuptools_hg.spec
Srpm url : http://kumarpraveen.fedorapeople.org/setuptools-hg/python-setuptools_hg-0.2.1-2.fc15.src.rpm

Koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3197955

Comment 3 Rahul Sundaram 2011-07-14 05:21:53 UTC

This looks good

===   APPROVED  ===

Comment 4 Praveen Kumar 2011-07-14 06:13:10 UTC

New Package SCM Request
=======================
Package Name: python-setuptools_hg
Short Description: Setuptools plugin for finding files under Mercurial version control
Owners: kumarpraveen
Branches: f14 f15

Comment 5 Gwyn Ciesla 2011-07-14 23:40:52 UTC

Git done (by process-git-requests).

Comment 6 Praveen Kumar 2011-07-15 16:44:55 UTC

Build Successfully, closed now.

Comment 7 James Hogarth 2015-12-04 02:45:34 UTC

This package is in rawhide but the review request bug was left open. Closing to tidy up the queue.