Bug 722440

Summary: [EL5.7 ixgbe] default WOL setting prevents system shutdown
Product: Red Hat Enterprise Linux 5 Reporter: Martin Wilck <martin.wilck>
Component: kernelAssignee: Andy Gospodarek <agospoda>
Status: CLOSED DUPLICATE QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: high Docs Contact:
Priority: unspecified    
Version: 5.7CC: agospoda, gasmith, jeffrey.t.kirsher, john.ronciak, ltroan, peterm
Target Milestone: beta   
Target Release: 5.8   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-09 18:12:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 708414    
Attachments:
Description Flags
proposed patch for 5.7 none

Description Martin Wilck 2011-07-15 11:04:18 UTC
Description of problem:
System with an ixgbe Adapter that supports WOL can't be switched off

Version-Release number of selected component (if applicable):
2.6.18-272.el5

How reproducible:
always

Steps to Reproduce:
1. install on system with an ixgbe Adapter that supports WOL (e.g. Fujitsu D2755)
2. don't make any changes to WOL settings
3. switch off system
  
Actual results:
System wakes up

Expected results:
System remains off until explicitly activated

Additional info:
The ixgbe driver activates all possible WOL methods (pumg) by default when WOL-capable hardware is detected. This is not the expected behavior. 

See https://bugzilla.redhat.com/show_bug.cgi?id=632598#c20 for a related discussion for RHEL6, attachment #409333 [details] for the patch that has been applied to RHEL6.1.

Comment 1 Martin Wilck 2011-07-15 11:05:42 UTC
Created attachment 513359 [details]
proposed patch for 5.7

Comment 2 Andy Gospodarek 2011-07-15 13:36:05 UTC
Thanks for bringing this to my attention, Martin.

I posted a patch upstream[1] and included this in RHEL6 since Intel promised to include it in their driver.  Unfortunately it never got added so when we pulled from upstream it was missed.  I should have followed up with Intel to make sure it was added upstream.

Adding Jeff to the cc-list to see if he can tell us when this will hit upstream or if there was a good reason it did not make it before.

1.  http://marc.info/?l=linux-netdev&m=130218725423253&w=2

Comment 3 Jeff Kirsher 2011-07-15 14:46:57 UTC
The patch that Andy posted on June 16th got accepted into the kernel on June 30.

http://patchwork.ozlabs.org/patch/57366/

Comment 4 Andy Gospodarek 2011-07-15 16:05:09 UTC
(In reply to comment #3)
> The patch that Andy posted on June 16th got accepted into the kernel on June
> 30.
> 
> http://patchwork.ozlabs.org/patch/57366/

That's not the same patch, Jeff.  

The patch we are talking about it from April.  Please check the link in comment #2.

Comment 5 Jeff Kirsher 2011-07-15 23:56:13 UTC
Oh, crap.  My bad, somehow this one slipped off my radar.  I have it currently in my queue for internal review and testing (Critical).  I can hopefully get this patch upstream early next week.  I apologize.

Comment 6 Larry Troan 2011-07-31 13:08:33 UTC
Tracker moved from FJ5.7Bugs to FTS5.8Bugs sonce 5.7 has shipped.

Comment 7 RHEL Program Management 2012-01-09 14:35:44 UTC
This request was evaluated by Red Hat Product Management for inclusion in Red Hat Enterprise Linux 5.8 and Red Hat does not plan to fix this issue the currently developed update.

Contact your manager or support representative in case you need to escalate this bug.

Comment 8 Martin Wilck 2012-01-09 15:49:39 UTC
Contrary to the bot message above, the fix for this problem is included in 5.8 snaphot 2 (2.6.18-302.el5). I suggest closing this bug.

Comment 9 Andy Gospodarek 2012-01-09 18:12:56 UTC
Thanks, Martin.  I was pretty sure that was the case.  Thanks for verification.

The RHEL bug was fixed as part of the major driver update for bug 714314.

This is also upstream, so everything looks good.

*** This bug has been marked as a duplicate of bug 714314 ***