Bug 722624

Summary:	there is hardcoded command line option in /etc/init.d/dkim-milter startup script, which overrides some conf file parameters
Product:	[Fedora] Fedora EPEL	Reporter:	Andrej Surkov <surae>
Component:	dkim-milter	Assignee:	Jim Radford <radford>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	el5	CC:	radford
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	dkim-milter-2.8.3-8.el5	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-08-05 08:28:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Andrej Surkov 2011-07-15 22:03:36 UTC

Description of problem:
There is hardcoded command line option "in /etc/init.d/dkim-milter startup script, which overrides some conf file parameters

Version-Release number of selected component (if applicable):
dkim-milter.i386 0:2.8.3-4.el5


How reproducible:


Steps to Reproduce:
1.Install dkim-milter package and set Socket parameter in dkim-milter.conf.
Say

Socket    inet:127.0.0.1:4445

2. restart dkim-milter service 
3. it turns out that dkim-filter daemon doesn't listen on network, but stil listens to socket file!
  
Actual results:
daemon doesn't listen on network port

Expected results:
daemon does listern on network port

Additional info:

There is a hardcoded option -p <socket filename> in start script - I've removed it manually (35'th string in /etc/init.d/dkim-milter script) and finally have got dkim-filter listening on network.

Comment 1 Jim Radford 2011-07-15 23:37:09 UTC

I agree, it really shouldn't be mentioned in the startup script.  Out of curiosity, why do you want to use the loopback instead of a socket file?

Comment 2 Andrej Surkov 2011-07-16 07:22:45 UTC

No particular reason for using loopback network, but this is the only way mentioned in HOWTOs I am following to setup a postfix e-mail gateway with DKIM signing. And honestly, I am not familiar with unix sockets - is it possible to set up 2 concurent connections via same socket file?

Comment 3 Jim Radford 2011-07-17 22:42:35 UTC

Generally unix sockets are safer because you can set permissions on them.  I believe you can tell postfix to use a socket by prefixing the socket file name with unix:.

It turns out that I fixed this bug already and it is el6, but I hadn't backported it to el5.  The new version will also includes a permissions fix for postfix.

Comment 4 Fedora Update System 2011-07-17 22:58:02 UTC

dkim-milter-2.8.3-8.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/dkim-milter-2.8.3-8.el5

Comment 5 Andrej Surkov 2011-07-18 02:46:16 UTC

Ok, thank you for your work :)

Comment 6 Fedora Update System 2011-07-20 15:31:46 UTC

Package dkim-milter-2.8.3-8.el5:
* should fix your issue,
* was pushed to the Fedora EPEL 5 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing dkim-milter-2.8.3-8.el5'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/dkim-milter-2.8.3-8.el5
then log in and leave karma (feedback).

Comment 7 Andrej Surkov 2011-07-21 05:11:11 UTC

Have tested updated package - it is ok! Sumbitted test record to fedora system.

Comment 8 Fedora Update System 2011-08-05 08:28:21 UTC

dkim-milter-2.8.3-8.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.