Bug 722679

Summary: thunar-vcs-plugin makes thunar randomly crash
Product: [Fedora] Fedora Reporter: Andrea Santilli <sacntct>
Component: thunar-vcs-pluginAssignee: Christoph Wickert <christoph.wickert>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 15CC: christoph.wickert, kevin
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-16 12:51:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
backtrace in daemon mode
none
workaround
none
workaround 2 none

Description Andrea Santilli 2011-07-16 12:08:24 UTC
Created attachment 513480 [details]
backtrace in daemon mode

Description of problem:
With the thunar-vcs-plugin installed, thunar can crash randomly when right-clicking on any spot of its icon view. That can happen at any time, even after a day in which thunar has been working fine.
I'm attaching a backtrace of a crash of thunar running in daemon mode.
From what I can see it crashes when it calls g_quark_from_static_string(). I'm still not sure why that's happening, it probably gets unloaded, and using g_quark_from_string() instead works for me. I'm attaching a patch too.

Version-Release number of selected component (if applicable):
0.1.4-1.fc15

How reproducible:
Sometimes

Steps to Reproduce:
1. install thunar-vcs-plugin
2. run thunar in daemon mode
3. after a while of normal work it can crash when right-clicking on any part of the icon view

Comment 1 Andrea Santilli 2011-07-16 12:09:11 UTC
Created attachment 513481 [details]
workaround

Comment 2 Christoph Wickert 2011-07-16 12:51:35 UTC
Yeah, I am aware of this problem and have already opened a bug report upstream at 
https://bugzilla.xfce.org/show_bug.cgi?id=6404

I have also added your patch to that bug now. Thanks a lot! I will issue an update this weekend for testing.

*** This bug has been marked as a duplicate of bug 584455 ***

Comment 3 Andrea Santilli 2011-07-16 13:37:02 UTC
Great, thanks!

Comment 4 Andrea Santilli 2011-07-16 14:03:19 UTC
Created attachment 513486 [details]
workaround 2

Oh sorry, just an errata: I did a bit of a mess when I recreated the patch and forgot to assign the g_quark_try_string() result. 
There's the fixed patch, now that works :)

Comment 5 Christoph Wickert 2011-07-16 14:27:14 UTC
Thanks, forwarded upstream.