Bug 722771 (wmeyes)

I'll review this one. :)

+ OK
- NA
? ISSUE

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
[ankur@ankur dump]$ md5sum wmeyes-1.2.tar.gz ~/rpmbuild/SOURCES/wmeyes-1.2.tar.gz 
bb687b5fea83d49b35552a181083142b  wmeyes-1.2.tar.gz
bb687b5fea83d49b35552a181083142b  /home/ankur/rpmbuild/SOURCES/wmeyes-1.2.tar.gz


- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package is code or permissible content.

defattr not required, you can remove it :)

- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
[ankur@ankur SRPMS]$ rpmlint  /var/lib/mock/fedora-rawhide-i386/result/*.rpm ../SPECS/wmeyes.spec wmeyes-1.2-3.fc15.src.rpm
wmeyes.i686: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Paddock
wmeyes.i686: I: enchant-dictionary-not-found de
wmeyes.i686: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, paddock
wmeyes.src: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Paddock
wmeyes.src: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, paddock
wmeyes.src: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Paddock
wmeyes.src: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, paddock
4 packages and 1 specfiles checked; 0 errors, 6 warnings.

^^ 
Ignorable.

+ final provides and requires are sane:
== wmeyes-1.2-3.fc16.i686.rpm ==
Provides:
wmeyes = 1.2-3.fc16
wmeyes(x86-32) = 1.2-3.fc16

Requires:
libICE.so.6  
libSM.so.6  
libX11.so.6  
libXext.so.6  
libXmu.so.6  
libXpm.so.4  
libXt.so.6  
libc.so.6  
libc.so.6(GLIBC_2.0)  
libc.so.6(GLIBC_2.1)  
libc.so.6(GLIBC_2.3.4)  
libm.so.6  
libm.so.6(GLIBC_2.0)  
rtld(GNU_HASH)  

== wmeyes-1.2-3.fc16.src.rpm ==
Provides:

Requires:
libXext-devel  
libXmu-devel  
libXpm-devel  
xmkmf  

== wmeyes-debuginfo-1.2-3.fc16.i686.rpm ==
Provides:
wmeyes-debuginfo = 1.2-3.fc16
wmeyes-debuginfo(x86-32) = 1.2-3.fc16

Requires:


SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Issues:


Clean package.  

XXX APPROVED XXX

Many thanks for your review. Before committing to the Git, I will drop the "defattr" line.

New Package SCM Request
=======================
Package Name: wmeyes
Short Description: Dockapp with moving eyes that follow mouse movement
Owners: mariobl
Branches: f15

Git done (by process-git-requests).

wmeyes-1.2-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/wmeyes-1.2-3.fc15

wmeyes-1.2-3.fc15 has been pushed to the Fedora 15 testing repository.

wmeyes-1.2-3.fc15 has been pushed to the Fedora 15 stable repository.