Bug 723012

List.cgi may be impacted as well.  As with Make, we do not want replicated values between bz and hwcert data.

The call home to create new cert we should not allow the request to create a new make however we should not fail the request either.

If the make value is found in the make table great, do the proper field values and move on.

If make value is not found in the make table, the call should still succeed but return a warn or error noting make not found.  Then the user can go to the website and either correct the selection from the dropdown or add the new make.


We can mimic Unknown Vendor but with a twist here.  When the user goes to the catalog the make dropdown can auto select the closest match to what was provided  The UI should highlight and require the vendor user to correct the make, but not require the reviewer to do so unless the reviewer tries to close/publish the cert.

If there are no close matches the dropdown can default to the make with the most # of uses in cert_records.  The new make text area should be populated with the value from the call.  The dropdown should be the default entry, and I believe we can do this by storing the value provided by the call whiteboard.

Created attachment 572600 [details]
sql to create makes table in hwcert db

Created attachment 572613 [details]
generate data for hwcert.makes table according to existing data

Created attachment 575270 [details]
use a dropdonw list to replace text input field for make

Comment on attachment 575270 [details]
use a dropdonw list to replace text input field for make

when trying to create a new cert with a result package got a software error:
Undefined subroutine &Hwcert::Vendor::SendSQL2 called at Hwcert/Vendor.pm line 316

Created attachment 576357 [details]
use a dropdonw list to replace text input field for make

fixed a bug in previous patch

Comment on attachment 576357 [details]
use a dropdonw list to replace text input field for make

works for me

Comment on attachment 576357 [details]
use a dropdonw list to replace text input field for make

we should import necessary modules to avoid this:
&::ThrowUserError, Bugzilla::DB::FetchOneColumn2().

(In reply to comment #9)
> Created attachment 572613 [details]
> generate data for hwcert.makes table according to existing data

This needs a test run/audit mode to be supported.  EG. what it would have done but without actually doing it to help verify before it messes with the data that the correct things would happen.  Also it needs output and a mode for after it was run to indicate which (if any) make titles it didn't create.

Created attachment 581527 [details]
generate data for hwcert.makes table according to existing data (with dry run function)

Created attachment 582852 [details]
generate data for hwcert.makes table according to existing data (with dry run function)

made two small changes for previous version
1. we don't generate make list for "unlisted vendor" vendor
2. the script won't output "invalid vendor" msg, which is useless and distracting here.

Verified on web2

Created attachment 584874 [details]
generate the statis sql queries(based on the data from live slave db) to add data into hwcert.makes table

Created attachment 584875 [details]
statis sql queries to add data to hwcert.makes

Created attachment 584876 [details]
makes table audit script

Verified on live.

Closing this bug.