Bug 723338

Summary: [PATCH] Also run javahl unit tests in %check
Product: [Fedora] Fedora Reporter: Blair Zajac <blair>
Component: subversionAssignee: Joe Orton <jorton>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: jorton, vanmeeuwen+fedora, ville.skytta
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-20 12:06:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch to subversion.spec to run javahl unit tests. none

Description Blair Zajac 2011-07-19 19:49:55 UTC
Description of problem: The javahl bindings are not checked in %check.

Version-Release number of selected component (if applicable): rawhide 1.6.16

Patch attached that runs these tests also.

Comment 1 Blair Zajac 2011-07-19 19:50:17 UTC
Update subject.

Comment 2 Blair Zajac 2011-07-19 19:54:59 UTC
Created attachment 513874 [details]
Patch to subversion.spec to run javahl unit tests.

Comment 3 Joe Orton 2011-07-20 09:56:26 UTC
Thanks!

It fails like this:

+ make check-javahl
/usr/lib/jvm/java/bin/java "-Dtest.rootdir=/builddir/build/BUILD/subversion-1.6.17
...
Time: 0.024
There were 50 errors:
1) testCreate(org.tigris.subversion.javahl.SVNAdminTests)java.lang.UnsatisfiedLinkError: no svnjavahl-1 in java.library.path

I guess we need to set LD_LIBRARY_PATH appropriately to pick up the buildroot's libsvnjavahl-1.so.  I'm having a look...

Comment 4 Joe Orton 2011-07-20 09:56:45 UTC
Forgot the reference: http://koji.fedoraproject.org/koji/taskinfo?taskID=3213926

Comment 5 Joe Orton 2011-07-20 10:22:06 UTC
Looks like we weren't passing --enable-javahl (!) and so the Makefile was not set up correctly...

Comment 7 Blair Zajac 2011-07-20 17:15:55 UTC
I did a git clone the other day and didn't see 1.6.17 in there.

Thanks for rolling it out!

Blair