Bug 723427
Summary: | Review Request: jinput - Java Game Controller API | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Guido Grazioli <guido.grazioli> | ||||
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | akurtako, loganjerry, notting, package-review, sochotni | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2012-02-13 20:15:40 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 723125 | ||||||
Bug Blocks: | 723779 | ||||||
Attachments: |
|
Description
Guido Grazioli
2011-07-20 06:47:39 UTC
This package suffers from this bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=633501 I see the same compiler warning and the same undefined symbol when building in Rawhide. Created attachment 516209 [details]
Patch to update the <linux/input.h> interface
FWIW, one fix is to change line 116 of plugins/linux/src/native/net_java_games_input_LinuxEventDevice.c from:
#if EV_VERSION >= 0x010001
to:
#ifdef EVIOCGUSAGE
But I think that fix is insufficient. Note that plugins/linux/src/java/net/java/games/input/NativeDefinitions.java is out of sync with /usr/include/linux/input.h, and regenerating it (with "ant -f plugins/linux/src/native/build.xml createNativeDefinitions.java") causes Java compilation to fail due to appearances of USAGE_* constants that no longer exist in <linux/input.h>. I think that NativeDefinitions.java should be regenerated, and all mention of the USAGE stuff should be ripped out, as in the attached patch.
Thanks for the info. USAGE constants must have been in the kernel headers for a very short time around kernel 2.6.18, i'm probably going to strip away any reference to them. When I saw the tests run successfully during the build I thought that bug was fixed upstream in trunk. I dont actually see a point in regenerating NativeDefinitions, as even if that file is regenerated, there's code that's built up on that version of the definitions. I can do the review of this. Do you want to first cleanup those issues with ifdefs or should I start? Thanks Stanislav, the clean up discussed above is definitely needed; please stand by for an updated package. Guido, can you give us an update on the status of this submission? Ping. Hello Jerry I have very little time atm to dedicate to this package and lwjgl, and wont get any more till mid January. We can consider this review request stalled, if nobody else would like to jump on it before. Well, I waited awhile for you anyway. :-) I have a package waiting for review that uses jinput, which explains my interest. If you haven't got time to move this forward, then may I hijack this review? Here's what I've done: http://jjames.fedorapeople.org/jinput/jinput.spec http://jjames.fedorapeople.org/jinput/jinput-2.0.6-1.20110801svn.fc16.src.rpm If you're okay with that ... what? Do I have to open a new bug, or can we keep using this one? Hello Jerry, I think you need to open a new review request bug, then close this one as a duplicate; please do it, just dont forget lwjgl as a dependent bug. Okay, I think I got it all. Poke me if I missed anything. *** This bug has been marked as a duplicate of bug 790172 *** |