Bug 723753

Summary:	System search submits to wrong URL on /available, /free, /mine
Product:	[Retired] Beaker	Reporter:	Dan Callaghan <dcallagh>
Component:	web UI	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	0.6	CC:	bpeck, dcallagh, mcsontos, rmancy, stl
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-08-12 02:43:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Dan Callaghan 2011-07-21 03:03:48 UTC

When accessing a system list at /available, /free, or /mine (as opposed to /available/, /free/, and /mine/ with a trailing slash, which is how they appear in Beaker's menu) the system search submits to the wrong location (always /). That's because the form has action=".". Instead it should be action="" so that the search is always submitted to the right place.

Maybe we should also redirect /available to /available/ (likewise for /free and /mine) so that if someone hits those URLs they will be redirected to the "canonical" version.

Tests in test_system_available.py are affected by this bug (or were, until Bill fixed them). Those tests should check the page title or use some other means to assert that they are in the right place after submitting the system search.

Comment 1 Steven Lawrance 2011-07-21 03:11:47 UTC

(In reply to comment #0)
> Maybe we should also redirect /available to /available/ (likewise for /free and
> /mine) so that if someone hits those URLs they will be redirected to the
> "canonical" version.

What's to be gained by doing this?  Seems like it would be just another request/roundtrip to slow things down for no reason.

Comment 2 Dan Callaghan 2011-07-25 01:00:41 UTC

(In reply to comment #1)
> What's to be gained by doing this?

Nothing really, except for consistency with the rest of Beaker (and the web in general). Cherrypy does this for us when the path is a sub-controller (so it makes it behave like a directory would in Apache).