Bug 723863

Hi Gerd,

Reviewing this patch set, i would like to classify them into three parts:
1) Companion controller related patches
2) Patches that can be tested through regular operation of qemu-kvm, like:
   usb-bus: Don't allow attaching a device to a bus with no free ports
   usb: Proper error propagation for usb_device_attach errors
3) Patches that can not be tested through regular operation of qemu-kvm, like:
   ehci: add freq + maxframes properties


For
patches in 1), have been verified in Bug 723858 usb: add companion controller support.
patches in 3), verify they are patched in the latest version, if you want me do more tests, please tell me the patch and method.


Try to verify following patches on qemu-kvm-0.12.1.2-2.184.el6.x86_64:
----------------------------------------------------------------------
usb-bus: Don't allow attaching a device to a bus with no free ports
usb: Proper error propagation for usb_device_attach errors


Steps and results:
-------------------
1.Boot guest with:
# /usr/libexec/qemu-kvm -enable-kvm -M rhel6.2.0 -smp 4 -m 4G -name rhel6.1-64 -uuid 3f2ea5cd-3d29-48ff-aab2-23df1b6ae213 -drive file=RHEL-Server-6.1-64-virtio.qcow2,cache=none,if=none,rerror=stop,werror=stop,id=drive-virtio-disk0,format=qcow2 -device virtio-blk-pci,drive=drive-virtio-disk0,id=device-virtio-disk0,bootindex=1 -netdev tap,script=/etc/qemu-ifup,id=netdev0 -device virtio-net-pci,netdev=netdev0,id=device-net0 -boot order=cd,menu=on -monitor stdio -vnc :30 -usb
QEMU 0.12.1 monitor - type 'help' for more information

2.In qemu monitor:

(qemu) device_add usb-tablet,port=1,id=input1
(qemu) device_add usb-tablet,port=2,id=input2
(qemu) device_add usb-tablet,id=input3
Error: tried to attach usb device QEMU USB Tablet to a bus with no free ports

Device 'usb-tablet' could not be initialized

(qemu) device_add usb-hub,id=usbhub1
(qemu) info usb
  Device 0.2, Port 1, Speed 12 Mb/s, Product QEMU USB Tablet
  Device 0.3, Port 2, Speed 12 Mb/s, Product QEMU USB Tablet
  Device 0.0, Port .1, Speed 12 Mb/s, Product QEMU USB Hub
(qemu) info qtree
      dev: piix3-usb-uhci, id ""
        dev-prop: masterbus = <null>
        dev-prop: firstport = 0
        bus-prop: addr = 01.2
        bus-prop: romfile = <null>
        bus-prop: rombar = 1
        bus-prop: multifunction = off
        class USB controller, addr 00:01.2, pci id 8086:7020 (sub 1af4:1100)
        bar 4: i/o at 0xc020 [0xc03f]
        bus: usb.0
          type USB
          dev: usb-hub, id "usbhub1"
            bus-prop: port = <null>
            addr 0.0, port .1, speed 12, name QEMU USB Hub, attached
          dev: usb-tablet, id "input2"
            dev-prop: migrate = 1
            bus-prop: port = "2"
            addr 0.3, port 2, speed 12, name QEMU USB Tablet, attached
          dev: usb-tablet, id "input1"
            dev-prop: migrate = 1
            bus-prop: port = "1"
            addr 0.2, port 1, speed 12, name QEMU USB Tablet, attached

3.In patch: Proper error propagation for usb_device_attach errors, there are several errors:

1) error_report("%s: no bus specified, using \"%s\" for \"%s\"\n", __FUNCTION__, bus->qbus.name, name);
2) error_report("Error: tried to attach usb device %s twice\n", dev->product_desc);
3) error_report("Error: tried to attach usb device %s to a bus with no free ports\n", dev->product_desc)
4) error_report("Error: usb port %s (bus %s) not found\n", dev->port_path, bus->qbus.name);
5) error_report("Error: tried to detach unattached usb device %s\n", dev->product_desc)

In usb device functional test we are running, we occur error 3 and 4, but never 1,2,5, could you please tell us the method to meet these errors? We may need to add cases according to this.


Conclusion:
--------------
Problem in step 2 is probably the same or related with these two new bugs, i recommend you have a look:

Bug 735009 Qemu-kvm fails to prompt error when add usb-hub to a non-exist uhci port and qemu-kvm hangs when delete this usb-hub

and 

Bug 734995 Core dump when hotplug three usb-hub into the same port under both uhci and ehci


Currently i would like to set this patch set verified if:
1) the two bugs above are effective and fixed or they are not bugs.
2) verify the error 1,2,5 mentioned above
3) there is no more tests you want me to do with this patch set


Any advice? Thanks.

If you manage to make errors (2)+(5) show up you have found a bug in qemu.  It doesn't make that much sense to report them to the user, in fact I've just converted them to assert() in upstream qemu.

Error (1) seems to not trigger any more, at least the way which used to work for me doesn't work any more.  Looks like the error condition is catched and handled elsewhere now.

734995 is a real bug, busy fixing that one right now.
735009 is a duplicate.

Thanks Gerd, i will set this bug verified after 734995 fixed.

According to:
https://bugzilla.redhat.com/show_bug.cgi?id=734995#c11

This bug has been fixed.

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Bug wasn't present in any released version.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1531.html