Bug 724064 (BRMS-7)

Summary: Remove Guvnor reference from GUI
Product: [JBoss] JBoss Enterprise BRMS Platform 5 Reporter: Mark Little <mark.little>
Component: User InterfaceAssignee: Jervis Liu <jliu>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: medium    
Version: 5.0.0 CR1CC: mproctor
Target Milestone: ---   
Target Release: 5.0.1   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/BRMS-7
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-08-28 18:35:05 UTC Type: Task
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 724161    
Attachments:
Description Flags
brms-7.patch2 none

Description Mark Little 2008-12-09 14:31:32 UTC
Date of First Response: 2009-03-11 06:41:35

Comment 1 Mark Little 2009-03-10 19:03:31 UTC
Status?

Comment 2 trev 2009-03-11 10:41:35 UTC
Have not received new logos, building first IR without the changes

Comment 3 trev 2009-03-25 16:49:26 UTC
need to change the title in Guvnor.html, line 11. doing this as an overlay first before trying to fit it in the Maven profile

Comment 4 trev 2009-04-15 16:07:18 UTC
done, adding it in the  Maven profile covered in BRMS-62

Comment 5 Jaroslaw Kijanowski 2009-05-04 07:47:02 UTC
Link: Added: This issue is a dependency of BRMS-104


Comment 6 Jaroslaw Kijanowski 2009-05-04 07:47:41 UTC
See BRMS-104 for details

Comment 7 trev 2009-05-08 11:35:37 UTC
this string is in ./org.drools.guvnor.Guvnor/616AF7AB2E052B6063357E0512764537.cache.html
need to talk to Mic Neale about how best to handle it.  


Comment 8 trev 2009-05-08 11:36:27 UTC
changing priority to reflect priority of BRMS-84

Comment 9 Ryan Zhang 2009-05-21 08:07:55 UTC
The string is origined from drools-guvnor/src/main/java/org/drools/guvnor/client/messages/*.properties files via GWT code generation. That might mean more "Guvnor constant string is likely to appear in the future"

The name seems to be changed every time after code generation.  

Another conserve is that international supports will lead several output files(.html) to include "Guvnor" though BRMS-104 occassionly step the english version mine. 


Comment 10 Jervis Liu 2009-05-21 08:15:49 UTC
Ryan Zhang is working on this jira. 

Comment 11 Ryan Zhang 2009-05-21 10:55:10 UTC
I attach a patch for quick fix.

Only two i18n versions(english and spanish) "Guvnor" string were replaced because only these two html were generated so far by GWT.
  
I say quick fix means it might not suffer the potential changed(e.g more  html file to be generated in order to support  i18n or more "Guvnor" CONSTANT to be added in properties of the future version)



Comment 12 Ryan Zhang 2009-05-21 10:55:10 UTC
Attachment: Added: brms-7.patch2


Comment 13 Jervis Liu 2009-05-22 03:36:09 UTC
Patch applied. 

Comment 14 Len DiMaggio 2009-08-28 18:35:05 UTC
Unable to find 'Guvnor' in the UI - also cannot find it in:

[ldimaggi@ldimaggi BRMS]$ files=$(find . -name *.html -print)
[ldimaggi@ldimaggi BRMS]$ grep Guvnor $files | grep -v javadocs | grep -v "org.drools.guvnor.Guvnor"


Comment 15 Dana Mison 2009-09-25 10:40:44 UTC
added to BRMS 5.0 CP01 release notes as resolved:

BRMS-7
All references to the Guvnor project have been removed from the BRMS web UI.