| Summary: | Business Rule elements containing a fact that has been removed cannot be edited (in Guided editor) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise BRMS Platform 5 | Reporter: | Jiri Locker <jlocker> | ||||
| Component: | BRM (Guvnor) | Assignee: | manstis | ||||
| Status: | VERIFIED --- | QA Contact: | Jiri Locker <jlocker> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.1.0.ER2, 5.1.0.ER3, 5.1.0.ER4 | CC: | atangrin, lpetrovi, manstis | ||||
| Target Milestone: | ER3 | ||||||
| Target Release: | BRMS 5.3.1 GA | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | http://jira.jboss.org/jira/browse/BRMS-419 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: |
Previously, when a fact within the Business Rule element was removed, the rule could no longer be edited within the Guided Rule Editor. The particular section of the Guided Rule Editor that used that fact type would freeze and prevent editing. This has been resolved by allowing frozen sections to be deleted and recreated.
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-10-28 23:18:13 UTC | Type: | Feature Request | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Jiri Locker
2010-10-27 15:24:33 UTC
Attachment: Added: OutdatedRule.png Link: Added: This issue is related to GUVNOR-364 This is done by design. To the rule it's irrelevant if a fact has been removed, or is not part of the used working set. Either way it knows that it cannot get to the fact type used so it disables that part of the rule from being editable. How would you have it behave differently (please reopen jira with description) Done by design. Unless we have a better way of dealing with this I will place jira as resolved. I find it perfectly reasonable to not be able to edit a part of a rule if the fact that is used in it is no longer accessible. But it makes no sense to me that I can't remove the part of the rule that has no effect without making that fact available again. If the user doesn't have access to the fact any more, the disabled snippet will hang there forever (unless they make up a workaround). So, making the snippet disabled AND adding an enabled Remove button would make it perfect IMO. What do you think? Link: Added: This issue depends GUVNOR-1360 The related JIRA suggests this should be fixed already. Fixed as part of https://bugzilla.redhat.com/show_bug.cgi?id=851100 (which was a BRMS 5.3.1+ blocker+) If this was fixed in another BZ, shouldn't this be closed as a dup? No. This is not a duplicate issue, but the fix for the other BZ also fixed this one. So, 2 bugs, 1 fix. Different bugs. Hello Michael, the issue is fixed partially. Frozen rule elements under THEN section still cannot be removed. Please make them removable too. WHEN section looks good, thanks. Sorry I missed the RHS. Change made and pushed to github https://github.com/droolsjbpm/guvnor/commit/9b19a881c4ffc53044ef5a875db5d0c06c726941 Fix verified in BRMS 5.3.0.ER3. Correction: verified in BRMS 5.3.1. Hey Mike, It is not clear to me whether the work-around is still necessary. Do customers still need to delete and recreate the rule? Or is this no longer necessary? Also, thank you for the release notes text. -Doug (In reply to comment #15) > Hey Mike, > > It is not clear to me whether the work-around is still necessary. Do > customers still need to delete and recreate the rule? Or is this no longer > necessary? > > Also, thank you for the release notes text. > > -Doug Hi Doug, I've updated the release notes: the workaround is no longer required. Thanks for the update, Mike. I'll add those changes to the Release Notes. - Doug |