Bug 724544 (BRMS-491)

Attachment: Added: Screenshot-1.png

The related JIRA suggests this should be fixed already.

Change status to ON_QA to accept verification for this issue.

I can't exactly verify this. It looks definitely better, the message is good. 

But: 
The dialogue window, where you choose/type a path to the package and start the import, stays there during the import and is operable - you can try to import another package (it isn't imported though). You can close this window, click cancel (doesn't cancel the import), move it.

If you refresh your browser, the message about the import disappears.

While the dialogue window is still there, it appears as if the Guvnor page is loading, not so when you close it - which makes you thinks it's just stuck - even with the message still there.


While it's better than before, it is still slightly confusing.

Hi, can someone please attach a "big drl" to this issue so that I can play with it?

Created attachment 564870 [details]
big drl

Here you go, this took about 2 minutes to import (for me). If you need more, let me know.

Please verify this issue on ER5.

I don't see anything different. Could you perhaps describe what changes you made, please?

With the fix, it now works like below:

When you click the "Import" button, a "Creating package - please wait..."  dialogue window pops up and stays until the importing finishes. 

If you close the window, or click the Cancel, the importing stops and the "Creating package - please wait..." dialogue window goes away.

(In reply to comment #10)
> With the fix, it now works like below:
> 
> When you click the "Import" button, a "Creating package - please wait..." 
> dialogue window pops up and stays until the importing finishes. 
> 
> If you close the window, or click the Cancel, the importing stops and the
> "Creating package - please wait..." dialogue window goes away.

The Cancel does not cancel the import. Try it, click Cancel and look into the server log. Or refresh and look into the packages - there's one being imported still. You can watch the progress if you expand the Technical rules assets tab (if you use the provided .drl) and hit the Refresh list button repeatedly (there are 440 rules total).
The same goes for closing the import dialogue.
Refreshing the page while importing still does the same as described before.

If you click cancel during the importing, the result will be unpredictable. It depends on if the full request has hit the server or not. If the request has already reached the server, the cancel will take no effect. 

I believe it should be possible to improve the way how Guvnor UI handles canceling, but this topic itself is probably worth a separate bugzilla issue. It wont be a simple fix.

(In reply to comment #12)
> If you click cancel during the importing, the result will be unpredictable. It
> depends on if the full request has hit the server or not. If the request has
> already reached the server, the cancel will take no effect. 
> 
> I believe it should be possible to improve the way how Guvnor UI handles
> canceling, but this topic itself is probably worth a separate bugzilla issue.
> It wont be a simple fix.


This never was about cancelling the import. The problem is that in the current state, import of large packages is a confusing experience for the user. It leaves him/her irrelevant options (Cancel and Import after already clicking on Import) and doesn't really show what's going on.

To make it better, you could make the message about the package being imported more (much more) visible. If it would be possible to make the message stay visible even after refresh (while the import is still in progress), it would be perfect. 
Also, it would be good to close the dialogue after the user clicks on Import - the dialogue does not serve any further purpose, just makes it more confusing.
It might be a nice touch to make the message about the package being imported "modal". In the sense that the user would have to wait until the import finished, before he/she could do more work in Guvnor. But making the message stay and be more visible would be enough.

Could you, please, look at it again?

Thanks for the suggestions. I've made the "Creating package - please wait..." popup modal so that users wont be able to click cancel or import button if the importing is already in process. Please let me know if this fix looks good to you. 

BTW, it is a good idea to close the dialogue after the user clicks on Import. However this option is not possible due to our current UI layout designs. This is because the "Create a new Package" wizard is the parent of "Creating package - please wait..." popup. If we close the "Create a new Package" wizard, the "Creating package - please wait..." popup will be closed automatically as well. 

It is possible to make the message stay visible after refresh (while the import is still in progress). However this will a quite big feature request. I've seen some webpages with this kind of similar features, which are implemented with HTML 5 local storage.

(In reply to comment #14)
> Thanks for the suggestions. I've made the "Creating package - please wait..."
> popup modal so that users wont be able to click cancel or import button if the
> importing is already in process. Please let me know if this fix looks good to
> you. 

This sounds good. I look forward to verifying that.

 
> BTW, it is a good idea to close the dialogue after the user clicks on Import.
> However this option is not possible due to our current UI layout designs. This
> is because the "Create a new Package" wizard is the parent of "Creating package
> - please wait..." popup. If we close the "Create a new Package" wizard, the
> "Creating package - please wait..." popup will be closed automatically as well. 
> 
> It is possible to make the message stay visible after refresh (while the import
> is still in progress). However this will a quite big feature request. I've seen
> some webpages with this kind of similar features, which are implemented with
> HTML 5 local storage.

Yeah, I guessed. I'll make put into a separate bugzilla, so that we can keep track of it. We can give it 'future' as the target release, or whatever, but it would be good to have some record. The 'refresh issue' is still something people will run into.

Update status to ON_QA. Please verify them against ER6.

This is much better, thanks.

I'd still like to offer feedback on some minor, cosmetic issues, perhaps for some future clean-up: 
Clicking the import button makes the button pressed down - it stays like that if the Guvnor tab in the browser is active. Clicking away from the browser makes it look okay. Until you switch back to the browser. 
If you move your cursor over the buttons, it changes, as if the buttons could be clicked, even though they can't (which is right and works, thanks).


To sum up the resolution (it would probably be good to include something like this in a note in the docs) - you choose to import a package. You then select a package to import from your file system and click Import. This begins the import and "Creating package - please wait..." pop-up will appear. While this is visible, the import dialogue is not operable. You should NOT refresh the page - the message would disappear (https://bugzilla.redhat.com/show_bug.cgi?id=807643). After the import is finished, you get a dialogue telling you so. Confirm and continue your work.

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
When importing a large package in the BRMS user interface, users previously received no feedback to signal the import was in progress. This has been resolved a message is now displayed stating, "Creating package - please wait…".