Bug 724991
| Summary: | Review Request: smokegen - Smoke Generator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Than Ngo <than> |
| Component: | Package Review | Assignee: | Jaroslav Reznik <jreznik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jreznik, notting, package-review |
| Target Milestone: | --- | Flags: | jreznik:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-07-27 15:22:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Than Ngo
2011-07-22 14:20:05 UTC
Spec URL: http://than.fedorapeople.org/rawhide/smokegen.spec SRPM URL: http://than.fedorapeople.org/rawhide/smokegen-4.6.95-1.fc15.src.rpm Description: Smoke Generator Split packaging for smokegen. Name: ok, matches upstream Summary: ok Group: ok, but not needed anymore License: not ok, LGPLv2 and GPLv2+ (according to discussion with Rex - legal wants us to list all licenses included in tarball) Url: not ok, redirects to Techbase and no article can be found there Source: ok (md5sum dd8dc0f9fb8e2fe5294075855be524a4) Obsoletes/Provides: ok?, smokegen was part of kdebindings (can all smoke* related packages provide kdebindigs?) Description: could be, I'd like to provide more information there, not a blocker Ldconfig: ok Docs: ok, just ping upstream for proper COPYING Shouldn't we have smokegen-devel? The same way as original kdebindings had it? Group, BuildRoot, clean section, defattrs not needed anymore rpmlint rpmlint smokegen-4.6.95-1.fc15.src.rpm smokegen.src: W: invalid-url URL: http://developer.kde.org/language-bindings/ HTTP Error 404: Not Found > fix pls smokegen.src: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/stable/4.6.95/src/smokegen-4.6.95.tar.bz2 <urlopen error ftp error: 550 Failed to change directory.> 1 packages and 0 specfiles checked; 0 errors, 2 warnings. > ok, we will have stable soon new smokegen-4.7.0-1.fc15.src.rpm is uploaded on http://than.fedorapeople.org/rawhide/ it should fix above issues. >Group, BuildRoot, clean section, defattrs not needed anymore we want to keep it in case we want to build for old release. Thanks Than. rpmlint smokegen-4.7.0-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Seems clean, just fix formatting a little bit, not a blocker for review. APPROVED Thanks! New Package SCM Request ======================= Package Name: smokegen Short Description: Smoke Generator Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Branches: f15 f16 Git done (by process-git-requests). imported and built http://koji.fedoraproject.org/koji/taskinfo?taskID=3233996 |