Bug 725139
| Summary: | Review Request: lastuser - User management application | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Praveen Kumar <kumarpraveen.nitdgp> |
| Component: | Package Review | Assignee: | pjp <pj.pandit> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fdc, metherid, notting, package-review, pj.pandit |
| Target Milestone: | --- | Flags: | pj.pandit:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-01-10 23:18:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 724006, 724864, 724869 | ||
|
Description
Praveen Kumar
2011-07-23 05:02:59 UTC
[X] Package name - ok. [X] Package group - ok. [?] Package license - the source tarball does not have license text copy. Please write to the upstream and request them to add a LICENSE/COPYING file to the source. [?] Build requires following packages to be installed. Please add them to the SPEC file. - BuildRequire: python-flask-mail - BuildRequire: python-flask-webassets - BuildRequire: python-wtforms - BuildRequire: python-flask-wtf - BuildRequire: pytz [X ]$ rpmlint SPECS/python-lastuser.spec SPECS/python-lastuser.spec: W: invalid-url Source0: lastuser-0.1.20110722git584fe0.tar.xz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. - ok. [X] $ rpmlint SRPMS/python-lastuser-0.1-1.20110722git584fe0.fc14.src.rpm python-lastuser.src: W: invalid-url Source0: lastuser-0.1.20110722git584fe0.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. - ok. [X] $ rpmlint RPMS/noarch/python-lastuser-0.1-1.20110722git584fe0.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. - ok. [X] Install/Uninstall - ok. rename to lastuser. apparently this doesn't function as a module at all Renamed.Added licence file and buildrequire. Spec URL: http://kumarpraveen.fedorapeople.org/lastuser/lastuser.spec SRPM URL: http://kumarpraveen.fedorapeople.org/lastuser/lastuser-0.1-2.20110724gitf41a49.fc15.src.rpm [?] Spec file has the same ChangeLog message. (In reply to comment #4) > [?] Spec file has the same ChangeLog message. Sorry, my mistake. Spec URL: http://kumarpraveen.fedorapeople.org/lastuser/lastuser.spec SRPM URL:http://kumarpraveen.fedorapeople.org/lastuser/lastuser-0.1-2.20110724gitf41a49.fc15.src.rpm [X] Package name - ok. [X] Package group - ok. [X] Package license - ok. [X] Build successful - ok. [X ]$ rpmlint SPECS/lastuser.spec SPECS/lastuser.spec: W: invalid-url Source0: lastuser-0.1.20110724gitf41a49.tar.xz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. - ok. [X] $ rpmlint SRPMS/lastuser-0.1-2.20110724gitf41a49.fc14.src.rpm lastuser.src: W: invalid-url Source0: lastuser-0.1.20110724gitf41a49.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. - ok. [X] $ rpmlint RPMS/noarch/lastuser-0.1-2.20110724gitf41a49.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. - ok. [X] Install/Uninstall - ok. Approved. New Package SCM Request ======================= Package Name: lastuser Short Description: User management application Owners: sundaram pjp kumarpraveen Branches: f14 f15 el6 Git done (by process-git-requests). Built and shipped. Closing. |