Bug 725243
| Summary: | Review Request: gespeaker - A GTK+ frontend for eSpeak and mbrola | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Raphael Groner <projects.rg> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DEFERRED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | martin.gieseking, notting, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-11-26 18:28:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Raphael Groner
2011-07-24 15:29:59 UTC
Hi Raphael, here are some quick comments on your package: - the license of the program is GPLv2+ because of the addition "or (at your option) any later version" in the copyright notice. - replace BR: python > 2.4 with BR: python2-devel - The package doesn't seem to provide arch-dependent files. Thus add BuildArch: noarch - the .desktop file must be verified with desktop-file-validate http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - patch the .desktop file to not use absolute paths (Exec and Icon) - see here how to install the locale files properly: http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files - Drop the asterisk from %{_datadir}/%{name}/* for proper directory ownership. - replace %{_mandir}/man1/%{name}.1.gz with %{_mandir}/man1/%{name}.1* - drop the empty %doc line in %files - the documentation should be installed into %{_defaultdocdir}/%{name}-%{version}. The easiest way to do that is to remove the installed docs from the buildroot and add it with %doc: * add rm -rf %{buildroot}%{_datadir}/doc/ to %install * add %doc doc/ to %files * remove %{_defaultdocdir}/%{name}/* from %files This also adds the missing file "copyright" Have a look at the packaging guidelines for further information: http://fedoraproject.org/wiki/Packaging:Python http://fedoraproject.org/wiki/PackagingGuidelines (In reply to comment #1) > * add %doc doc/ to %files Oops, I meant %doc doc/* here. I doubt that I can maintain the package. Someone interested to take it? |