Bug 725367

Summary: invalid command ipvsadm --stop-daemon (pulse.c)
Product: Red Hat Enterprise Linux 5 Reporter: Rita Zoppi <rita.zoppi>
Component: piranhaAssignee: Ryan O'Hara <rohara>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: high Docs Contact:
Priority: medium    
Version: 5.6CC: cluster-maint, djansa, maurizio.antillon, mjuricek
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: piranha-0.8.4-24.el5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 749594 (view as bug list) Environment:
Last Closed: 2012-02-21 06:34:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
patch to temporarly fix this issue and SELinux policy
none
Add master and backup parameters to ipvsadm --stop-daemon. none

Description Rita Zoppi 2011-07-25 10:25:54 UTC
Created attachment 515006 [details]
patch to temporarly fix  this issue and SELinux policy

Description of problem: in the source code pulse.c the ipvsadm --stop-daemon syntax is incorrect
orig: 
-  ipvsadmArgs[0] = (char *) config->vsadm;
-  ipvsadmArgs[1] = (char *) "--stop-daemon";
-  ipvsadmArgs[2] = NULL;

[root@lvs01 ~]# ipvsadm --stop-daemon
Try `ipvsadm -h' or 'ipvsadm --help' for more information.
The correct syntax are:
ipvsadm --stop-daemon [master|backup]

Version-Release number of selected component (if applicable):

all
How reproducible:
ipvsadm --stop-daemon
Try `ipvsadm -h' or 'ipvsadm --help' for more information.

Steps to Reproduce:
1.
2.
3.
  
Actual results:
manually shell command
[root@lvs01 ~]# ipvsadm --stop-daemon
Try `ipvsadm -h' or 'ipvsadm --help' for more information.

Expected results:
the ipvsadm daemon should stop after command
ipvsadm --stop-daemon [master|backup]


Additional info:
I wrote a patch to temporarly fix  this issue (search in the proc pseudofilesystem which daemon is active and then stop the daemon) In attach the patch and the SELinux policy. I also added run time flags to enable debug flags

Comment 1 Ryan O'Hara 2011-10-12 18:29:22 UTC
How are you recreating this problem in pulse?

Comment 4 Ryan O'Hara 2011-10-27 15:30:36 UTC
Created attachment 530518 [details]
Add master and backup parameters to ipvsadm --stop-daemon.

Previously, pulse used only 'ipvsadm --stop-daemon'. This command no longer works and either the state param (master or backup) is required. This patch adds ',aster' and 'daemon' to the 'ipvsadm --stop-daemon' command. Also, 'ipvsadm --stop-daemon' is now called twice. Once to stop the master sync daemon, once to stop the backup sync daemon.

Comment 8 errata-xmlrpc 2012-02-21 06:34:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0262.html