Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
When I fetch two(or more) extra attr data from CIFS files using getfattr, I get wrong data. I scan source code(2.6.32-170), find CIFSSMBQAllEAs parse wrongly the data which is returned by SMB messages.
Test steps:
[root@amd-pike-02 ~]# setfattr -n user.test -v test /mnt/test/test
[root@amd-pike-02 ~]# setfattr -n user.test1 -v test1 /mnt/test/test
[root@amd-pike-02 ~]# setfattr -n user.1test -v 1test /mnt/test/test
[root@amd-pike-02 ~]# getfattr -d /mnt/test/test
getfattr: Removing leading '/' from absolute path names
# file: mnt/test/test
user.1test="1test"
user.security.selinux="unconfined_u:object_r:default_t:s0
user.test="test"
user.test1="test" <----- should be "test1"
[root@amd-pike-02 ~]# getfattr -n user.test1 /mnt/test/test
getfattr: Removing leading '/' from absolute path names
# file: mnt/test/test
user.test1="test" <------ should be "test1"
Analysis:
[fs/cifs/cifssmb.c]
[5815]
name_len = temp_fea->name_len;
<snip>
[5825]
if (ea_name) {
if (strncmp(ea_name, temp_ptr, name_len) == 0) {
----ea_name="test1" temp_ptr="test" name_len=4
----if (ea_name && strnlen(ea_name,0x1000) == name_len)) .....
(In reply to comment #0)
> Description of problem:
> When I fetch two(or more) extra attr data from CIFS files using getfattr, I
Execute, mistake extended attribute with extra attribute
Comment 5RHEL Program Management
2011-07-26 18:40:16 UTC
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products. This request is not yet committed for inclusion in an Update release.
Nice catch. Doesn't look too tough to fix -- just need to make sure we match the length of names before the strncmp. I sent a patch upstream to fix this. If it gets pushed for 3.1 in the near future, I'll plan to put this in RHEL6.2.
http://article.gmane.org/gmane.linux.kernel.cifs/3808
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
http://rhn.redhat.com/errata/RHSA-2011-1530.html
Description of problem: When I fetch two(or more) extra attr data from CIFS files using getfattr, I get wrong data. I scan source code(2.6.32-170), find CIFSSMBQAllEAs parse wrongly the data which is returned by SMB messages. Test steps: [root@amd-pike-02 ~]# setfattr -n user.test -v test /mnt/test/test [root@amd-pike-02 ~]# setfattr -n user.test1 -v test1 /mnt/test/test [root@amd-pike-02 ~]# setfattr -n user.1test -v 1test /mnt/test/test [root@amd-pike-02 ~]# getfattr -d /mnt/test/test getfattr: Removing leading '/' from absolute path names # file: mnt/test/test user.1test="1test" user.security.selinux="unconfined_u:object_r:default_t:s0 user.test="test" user.test1="test" <----- should be "test1" [root@amd-pike-02 ~]# getfattr -n user.test1 /mnt/test/test getfattr: Removing leading '/' from absolute path names # file: mnt/test/test user.test1="test" <------ should be "test1" Analysis: [fs/cifs/cifssmb.c] [5815] name_len = temp_fea->name_len; <snip> [5825] if (ea_name) { if (strncmp(ea_name, temp_ptr, name_len) == 0) { ----ea_name="test1" temp_ptr="test" name_len=4 ----if (ea_name && strnlen(ea_name,0x1000) == name_len)) .....