Bug 725540

Summary: [vdsm] vdsClient - KeyError: 'fullTargets' when running discoverST with portal and without port
Product: [Retired] oVirt Reporter: Haim <hateya>
Component: vdsmAssignee: Dan Kenigsberg <danken>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: abaron, bazulay, danken, iheim, mgoldboi, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.1   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: vdsm-4.9.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-09 08:01:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Haim 2011-07-25 19:35:28 UTC
Description of problem:

when running the following command: 

vdsClient -s 0 discoverST host: i get: 

[root@rhev-a24c-01 ~]# vdsClient -s 0 discoverST 10.35.65.25:
---- fullTargets
Traceback (most recent call last):
  File "/usr/share/vdsm/vdsClient.py", line 1987, in <module>
    code, message = commands[command][0](commandArgs)
  File "/usr/share/vdsm/vdsClient.py", line 549, in discoverST
    for target in targets['fullTargets']:
KeyError: 'fullTargets'

this works either with 'host:port' or 'host' alone but not with 'host:'.

Comment 3 Dan Kenigsberg 2011-07-25 20:06:02 UTC
Please add vdsm.log - I wonder what was the return code from the server.
The fix should be very similar to what we discussed about the "list" verb: vdsClient should check the return code before assuming that data exist.

And yes, let's solve this non-urgent issue upstream.

Comment 5 Dan Kenigsberg 2011-10-14 09:53:49 UTC
http://gerrit.usersys.redhat.com/1031

Comment 6 Dan Kenigsberg 2011-10-24 21:21:35 UTC
*** Bug 744685 has been marked as a duplicate of this bug. ***

Comment 8 Haim 2012-01-25 07:12:42 UTC
sorry - still happens: 

[root@nott-vds1 ~]# vdsClient -s 0 discoverST 10.35.65.25:
---- fullTargets
Traceback (most recent call last):
  File "/usr/share/vdsm/vdsClient.py", line 1987, in <module>
    code, message = commands[command][0](commandArgs)
  File "/usr/share/vdsm/vdsClient.py", line 549, in discoverST
    for target in targets['fullTargets']:
KeyError: 'fullTargets'

[root@nott-vds1 ~]# rpm -q vdsm 
vdsm-4.9-112.5.el6_2.x86_64

Comment 9 Dan Kenigsberg 2012-01-25 09:46:39 UTC
Odd. Could you type in the returned result of discoverSendTargets (from Vdsm log)?

Comment 10 Dan Kenigsberg 2012-01-25 09:49:16 UTC
Not odd at all - the bug was fixed 4.9.1 (v4.9.0-214-ge6cc110) and not available of the specified 4.9.

Comment 11 Itamar Heim 2012-08-09 08:01:52 UTC
closing ON_QA bugs as oVirt 3.1 was released:
http://www.ovirt.org/get-ovirt/

Comment 12 Itamar Heim 2012-08-09 08:03:24 UTC
closing ON_QA bugs as oVirt 3.1 was released:
http://www.ovirt.org/get-ovirt/