Bug 725555

Description of problem:

Catalina.out returns the error 

"ERROR com.redhat.rhn.common.hibernate.HibernateFactory - Query exectued with Collection larger than 1000" when searching packages"

Version-Release number of selected component (if applicable):
Spacewalk 1.6

How reproducible:
100%

Steps to Reproduce:
1. Using the webUI or API, search for a package kernel (or some package which number is higher than 100)

  
Actual results:

"ERROR com.redhat.rhn.common.hibernate.HibernateFactory - Query exectued with Collection larger than 1000" when searching packages" is showed at catalina.out

Expected results:

ERROR be shown when searching larger than 100 packages


Additional info:


Looking the function bindParameters(), we can observe that there is typo. The if condition takes 100 instead 1000. 


java/code/src/com/redhat/rhn/common/hibernate/HibernateFactory.java
----------------------------------------------------------------------------
124     private Query bindParameters(Query query, Map parameters)
125         throws HibernateException {
126         if (parameters == null) {
127             return query;
128         }
129 
130         Set entrySet = parameters.entrySet();
131         for (Iterator itr = entrySet.iterator(); itr.hasNext();) {
132             Map.Entry entry = (Map.Entry) itr.next();
133             if (entry.getValue() instanceof Collection) {
134                 Collection c = (Collection) entry.getValue();
135                 if (c.size() > 100) {
136                     LOG.error("Query exectued with Collection larger than 1000");
137                 }
138                 query.setParameterList((String) entry.getKey(), c);
139             }
140             else {
141                 query.setParameter((String) entry.getKey(), entry.getValue());
142             }
143         }
144 
145         return query;
146     }