Bug 725587

Trying to squeeze this in before feature deadline tomorrow. :)

$ rpmlint condor-cloud-0.1-2.fc15.src.rpm condor-cloud.spec 
1 packages and 1 specfiles checked; 0 errors, 0 warnings.

[clalance@localhost SPECS]$ rpmlint ../RPMS/noarch/condor-cloud-0.1-2.fc14.noarch.rpm
condor-cloud.noarch: E: script-without-shebang /usr/libexec/condor/cloud_functions
condor-cloud.noarch: E: non-standard-dir-perm /var/lib/condor-cloud/local_cache 0711L
condor-cloud.noarch: W: non-conffile-in-etc /etc/condor/config.d/50condor_cloud.config
condor-cloud.noarch: W: empty-%post
condor-cloud.noarch: W: empty-%postun
1 packages and 0 specfiles checked; 2 errors, 3 warnings.

[clalance@localhost SPECS]$ rpmlint ../RPMS/noarch/condor-cloud-node-0.1-2.fc14.noarch.rpm
condor-cloud-node.noarch: E: script-without-shebang /usr/libexec/condor/cloud_functions
condor-cloud-node.noarch: E: non-standard-dir-perm /var/lib/condor-cloud/local_cache 0711L
condor-cloud-node.noarch: W: non-conffile-in-etc /etc/condor/config.d/50condor_cloud_node.config
1 packages and 0 specfiles checked; 2 errors, 1 warnings.

So, let's see.  For the script without a shebang, we can ignore the error, since that is allowed with what we are doing here.  We should change the non-standard permissions to a standard 755, or 700 if it is sensitive.  We should also mark the config file /etc/condor/config.d/50condor_cloud_node.config as %config.  Finally, both condor-cloud and condor-cloud-node own the same files.  I think the intention here is that they live on separate machines; if that is the case, then they should Conflicts with each other, since they own the same files.

I'll do another post with other parts of the review, but this is enough to get started.

OK, addressed the above and uploaded new packages/specfile.

http://imain.fedorapeople.org/condor_cloud/condor-cloud-0.1-3.fc15.src.rpm

OK, the new -3 version is much better, rpmlint is happier.

[  OK  ] MUST: rpmlint must be run on every package
[  OK  ] MUST: The package must be named according to the Package Naming 
         Guidelines
[  OK  ] MUST: The spec file name must match the base package %{name} [...]
[  OK  ] MUST: The package must meet the Packaging Guidelines
The Source of the package must be the full URL to the released tarball.
[  OK  ] MUST: The package must be licensed with a Fedora approved license
         and meet the Licensing Guidelines
[ FAIL ] MUST: The License field in the package spec file must match the 
         actual license - clalance: missing a license file
[  N/A ] MUST: If (and only if) the source package includes the text of the 
         license(s) in its own file, then that file, containing the text of 
         the license(s) for the package must be included in %doc
[  OK  ] MUST: The spec file must be written in American English.
[  OK  ] MUST: The spec file for the package MUST be legible.
[  OK  ] MUST: The sources used to build the package must match the
upstream 
         source, as provided in the spec URL. Reviewers should use md5sum for 
         this task. If no upstream URL can be specified for this package, 
         please see the Source URL Guidelines for how to deal with this.
[  OK  ] MUST: The package MUST successfully compile and build into binary 
         rpms on at least one primary architecture
[  N/A ] MUST: If the package does not successfully compile, build or work on 
         an architecture, then those architectures should be listed in the 
         spec in ExcludeArch. Each architecture listed in ExcludeArch MUST 
         have a bug filed in bugzilla, describing the reason that the package 
         does not compile/build/work on that architecture. The bug number MUST 
         be placed in a comment, next to the corresponding ExcludeArch line
[  OK  ] MUST: All build dependencies must be listed in BuildRequires, except 
         for any that are listed in the exceptions section of the Packaging 
         Guidelines ; inclusion of those as BuildRequires is optional. Apply 
         common sense.
[  N/A ] MUST: The spec file MUST handle locales properly. This is done by 
         using the %find_lang macro. Using %{_datadir}/locale/* is strictly 
         forbidden
[  N/A ] MUST: Every binary RPM package (or subpackage) which stores shared 
         library files (not just symlinks) in any of the dynamic linker's 
         default paths, must call ldconfig in %post and %postun.
[  N/A ] MUST: If the package is designed to be relocatable, the packager must 
         state this fact in the request for review, along with the 
         rationalization for relocation of that specific package. Without 
         this, use of Prefix: /usr is considered a blocker.
[  OK  ] MUST: A package must own all directories that it creates. If it does 
         not create a directory that it uses, then it should require a package 
         which does create that directory.
[  OK  ] MUST: A package must not contain any duplicate files in the %files 
         listing.
[  OK  ] MUST: Permissions on files must be set properly. Executables should 
         be set with executable permissions, for example.
[  OK  ] MUST: Each package must consistently use macros.
[  OK  ] MUST: The package must contain code, or permissable content.
[  OK  ] MUST: Large documentation files must go in a -doc subpackage. (The 
         definition of large is left up to the packager's best judgement, but 
         is not restricted to size. Large can refer to either size or 
         quantity).
[  OK  ] MUST: If a package includes something as %doc, it must not affect the 
         runtime of the application. To summarize: If it is in %doc, the 
         program must run properly if it is not present.
[  N/A ] MUST: Header files must be in a -devel package.
[  N/A ] MUST: Static libraries must be in a -static package.
[  N/A ] MUST: Packages containing pkgconfig(.pc) files must 'Requires: 
         pkgconfig' (for directory ownership and usability).
[  N/A ] MUST: If a package contains library files with a suffix (e.g. 
         libfoo.so.1.1), then library files that end in .so (without suffix) 
         must go in a -devel package.
[  N/A ] MUST: In the vast majority of cases, devel packages must require the 
         base package using a fully versioned dependency: Requires: %{name} =
         %{version}-%{release}
[  N/A ] MUST: Packages must NOT contain any .la libtool archives, these must 
         be removed in the spec if they are built.
[  N/A ] MUST: Packages containing GUI applications must include a
         %{name}.desktop file, and that file must be properly installed with 
         desktop-file-install in the %install section. If you feel that your 
         packaged GUI application does not need a .desktop file, you must put 
         a comment in the spec file with your explanation.
[  OK  ] MUST: Packages must not own files or directories already owned by 
         other packages. The rule of thumb here is that the first package to 
         be installed should own the files or directories that other packages 
         may rely upon. This means, for example, that no package in Fedora 
         should ever share ownership with any of the files or directories 
         owned by the filesystem or man package. If you feel that you have a 
         good reason to own a file or directory that another package owns, 
         then please present that at package review time.
[  OK  ] MUST: All filenames in rpm packages must be valid UTF-8.

OK, so except for the licenses issue, this looks good to go.

Updated package looks good now.  APPROVED.

New Package SCM Request
=======================
Package Name: condor-cloud
Short Description: Condor based cloud solution.
Owners: imain
Branches: f16
InitialCC:

imain is not a FAS Account in the Packager group.

imain lost his membership because he didn't sign the CLA. He's a long standing packager. I sponsored his re-application for packager group membership.

Review looks good to me, approval stands.

(In reply to comment #9)
> imain lost his membership because he didn't sign the CLA.

the new FPCA, I meant

New Package SCM Request
=======================
Package Name: condor-cloud
Short Description: Condor based cloud solution.
Owners: imain
Branches: f16
InitialCC:

Git done (by process-git-requests).

Waterfowl now appear colinear.  Thanks all!

Thanks guys!  All built!

In docs it says to close bug as NEXTRELEASE, but I don't see that option?  Will set to RELEASE_PENDING.