Bug 725588

Summary: Repo edit not working
Product: [Retired] Katello Reporter: Partha Aji <paji>
Component: WebUIAssignee: Miroslav Suchý <msuchy>
Status: CLOSED NOTABUG QA Contact: Katello QA List <katello-qa-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 1.0CC: bbuckingham, msuchy, sghai
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-18 10:02:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 720829    
Bug Blocks:    

Description Partha Aji 2011-07-25 22:49:27 UTC
Description of problem:
Editing the name or URL of a repository results in a 400 Bad Request.

undefined method `values' for nil:NilClass

How reproducible:
always

Steps to Reproduce:
1. Create a custom product 
2. Create a repository
3. Now click on the repository edit
4. Change the name or url 
  
Actual results:
undefined method `values' for nil:NilClass
and 
Completed 400 Bad Request

Expected results:
Successful update of repo and product. 

Additional info:
The reason is because the repo id is not sent in the edit request. When we update a repo, a provider update is getting sent over without any reference to the repository getting updated.

Started POST "/providers/5" for 10.11.231.31 at Mon Jul 25 18:41:12 -0400 2011
  Processing by ProvidersController#update as HTML
  Parameters: {"repo"=>{"feed"=>"http://rgoo.com"}, "authenticity_token"=>"dUnf1zIsGIsLQNAd2k5c3QRLwsHK2bt9hy2zo7O/Q3U=", "id"=>"5"}


and


Started POST "/providers/5" for 10.11.231.31 at Mon Jul 25 18:18:28 -0400 2011
  Processing by ProvidersController#update as HTML
  Parameters: {"repo"=>{"name"=>"baz1221"}, "authenticity_token"=>"dUnf1zIsGIsLQNAd2k5c3QRLwsHK2bt9hy2zo7O/Q3U=", "id"=>"5"}

Notice in neither case is there any indication as to which repo changed.

Comment 1 Brad Buckingham 2011-07-25 23:53:06 UTC
Editing a repository is not currently supported; however, needs to be investigated.  It may require modification pulp and the katello backend.

Comment 2 Jason E. Rist 2011-08-03 19:21:20 UTC
Backend - related to 720829

Comment 3 Mike McCune 2011-09-07 19:22:24 UTC
*** Bug 735731 has been marked as a duplicate of this bug. ***

Comment 4 Miroslav Suchý 2012-08-21 16:15:56 UTC
The repository could not edited anymore. Can we close this BZ?

Comment 5 Miroslav Suchý 2012-12-18 09:56:38 UTC
taking

Comment 6 Miroslav Suchý 2012-12-18 10:02:44 UTC
closing per #4