Bug 725822

Summary: gtk-xfce-engine is not part of software group Xfce
Product: [Fedora] Fedora Reporter: Enrique <cquike>
Component: gtk-xfce-engineAssignee: Kevin Fenzi <kevin>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 15CC: cwickert, kevin, maxamillion
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-28 21:37:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Enrique 2011-07-26 16:51:32 UTC
Description of problem:

 I installed software group Xfce, but gtk-xfce-engine is not part of it.

Comment 1 Kevin Fenzi 2011-07-26 17:09:13 UTC
It's not required by any other part of Xfce. ;) 

I seem to recall there was some reason we didn't install it by default, but I can't recall what that was. 

Adding Christoph here.

Comment 2 Christoph Wickert 2011-07-26 21:10:40 UTC
I only remember we didn't install xfce4-icon-theme because it is broken and unmaintained, but for the gtk-engine I think it should definitely be in the Xfce group. I even think it should be 'default' rather than 'optional'.

... unless I didn't miss something fundamental here.

Comment 3 Kevin Fenzi 2011-07-27 23:32:35 UTC
ok. Shall we add it into comps? or add a dep somewhere? 
comps would make more sense, since there's no real dep on it, but then existing installs wouldn't get it.

Comment 4 Christoph Wickert 2011-07-28 05:47:29 UTC
I don't think this is a problem and comps is enough.

Comment 5 Kevin Fenzi 2011-07-28 16:11:23 UTC
ok, how about: 

diff --git a/comps-f15.xml.in b/comps-f15.xml.in
index 97a0165..de969ba 100644
--- a/comps-f15.xml.in
+++ b/comps-f15.xml.in
@@ -6779,6 +6779,7 @@
       <packagereq type="default">xfce4-power-manager</packagereq>
       <packagereq type="default">xfce4-session-engines</packagereq>
       <packagereq type="default">xfwm4-theme-nodoka</packagereq>
+      <packagereq type="default">gtk-xfce-engine</packagereq>
       <packagereq type="optional">parole</packagereq>
       <packagereq type="optional">ristretto</packagereq>
       <packagereq type="optional">thunar-media-tags-plugin</packagereq>
diff --git a/comps-f16.xml.in b/comps-f16.xml.in
index dca75c0..c93f1e8 100644
--- a/comps-f16.xml.in
+++ b/comps-f16.xml.in
@@ -6804,6 +6804,7 @@
       <packagereq type="default">xfce4-power-manager</packagereq>
       <packagereq type="default">xfce4-session-engines</packagereq>
       <packagereq type="default">xfwm4-theme-nodoka</packagereq>
+      <packagereq type="default">gtk-xfce-engine</packagereq>
       <packagereq type="optional">parole</packagereq>
       <packagereq type="optional">ristretto</packagereq>
       <packagereq type="optional">thunar-media-tags-plugin</packagereq>
diff --git a/comps-f17.xml.in b/comps-f17.xml.in
index dca75c0..c93f1e8 100644
--- a/comps-f17.xml.in
+++ b/comps-f17.xml.in
@@ -6804,6 +6804,7 @@
       <packagereq type="default">xfce4-power-manager</packagereq>
       <packagereq type="default">xfce4-session-engines</packagereq>
       <packagereq type="default">xfwm4-theme-nodoka</packagereq>
+      <packagereq type="default">gtk-xfce-engine</packagereq>
       <packagereq type="optional">parole</packagereq>
       <packagereq type="optional">ristretto</packagereq>
       <packagereq type="optional">thunar-media-tags-plugin</packagereq>

Comment 6 Christoph Wickert 2011-07-28 21:31:28 UTC
Please make sure to keep the alphabetical sorting order. The rest is ok.

Comment 7 Kevin Fenzi 2011-07-28 21:37:47 UTC
Done.