Bug 726014

Summary: Fix memleak on exit in virtio-balloon
Product: Red Hat Enterprise Linux 6 Reporter: Amit Shah <amit.shah>
Component: qemu-kvmAssignee: Amit Shah <amit.shah>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.2CC: juzhang, mkenneth, qzhang, shu, tburke, virt-maint
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-kvm-0.12.1.2-2.179.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 15:54:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Amit Shah 2011-07-27 10:25:41 UTC
Description of problem:

Unplugging a virtio-balloon device or exiting qemu doesn't free some RAM.  Adding an exit handler that calls virtio_cleanup() fixes the leak.

Comment 5 Shaolong Hu 2011-09-09 08:19:08 UTC
Verification of this bug is blocked by bug 736975.

Comment 6 Shaolong Hu 2011-10-10 04:50:22 UTC
According to:
https://bugzilla.redhat.com/show_bug.cgi?id=736975#c8

Bug 736975 has been fixed.

Reproduce and verify using steps in:
https://bugzilla.redhat.com/show_bug.cgi?id=726020#c7

Since from qemu 160, all version suffers from bug 736975, cannot reproduce this as a contrast, just verify the patch.

Verify on qemu-kvm-0.12.1.2-2.193.el6.x86_64:

used    free    buffers/cached             
181     7281          0/6             <---before start qemu
735     6726          0/9             <---start qemu
731     6730          0/9             <---after hotplug/unplug 300 times
182     7279          0/6             <---after exit qemu

According to above results, the patch works fine, verified.

However, there is another issue, once i did 300 times hotplug/unplug and check the result next morning, the used/free memory are 914/6547, i did two times more and check the result immediately after it finished, it looks like above one, seems when idle, qemu-kvm has memory leak? I will investigate this further. Any advice please let me know.

Comment 7 juzhang 2011-10-11 04:55:00 UTC
(In reply to comment #6)
> According to:
> https://bugzilla.redhat.com/show_bug.cgi?id=736975#c8
> 
> Bug 736975 has been fixed.
> 
> Reproduce and verify using steps in:
> https://bugzilla.redhat.com/show_bug.cgi?id=726020#c7
> 
> Since from qemu 160, all version suffers from bug 736975, cannot reproduce this
> as a contrast, just verify the patch.
> 
> Verify on qemu-kvm-0.12.1.2-2.193.el6.x86_64:
> 
> used    free    buffers/cached             
> 181     7281          0/6             <---before start qemu
> 735     6726          0/9             <---start qemu
> 731     6730          0/9             <---after hotplug/unplug 300 times
> 182     7279          0/6             <---after exit qemu
> 
> According to above results, the patch works fine, verified.
> 
> However, there is another issue, once i did 300 times hotplug/unplug and check
> the result next morning, the used/free memory are 914/6547, i did two times
> more and check the result immediately after it finished, it looks like above
> one, seems when idle, qemu-kvm has memory leak? I will investigate this
> further. Any advice please let me know.
I will set this issue as verified.about the potential issue,if you can identify it,please spilt it.

Comment 9 errata-xmlrpc 2011-12-06 15:54:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1531.html