Bug 726438

Summary: sssd doesn't honor ldap supportedControls
Product: Red Hat Enterprise Linux 6 Reporter: Joshua Roys <roysjosh>
Component: sssdAssignee: Stephen Gallagher <sgallagh>
Status: CLOSED ERRATA QA Contact: Chandrasekar Kannan <ckannan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.1CC: benl, dpal, grajaiya, jgalipea, jhrozek, kbanerje, nc, prc
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: sssd-1.5.1-46.el6 Doc Type: Bug Fix
Doc Text:
Cause: SSSD did not keep a copy of the list of supported LDAP controls during the whole LDAP operation. At the same time, it used the list of controls to determine if password expiration controls were available Consequence: Password expiration warnings did not work because SSSD thought they were not available Fix: SSSD always requests the expiration controls and only acts upon the controls actually being created or not. Result: Password expiration warnings are displayed
Story Points: ---
Clone Of:
: 748856 (view as bug list) Environment:
Last Closed: 2011-12-06 16:39:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 748856    
Attachments:
Description Flags
sssd debug logs none

Description Joshua Roys 2011-07-28 15:16:21 UTC
Created attachment 515750 [details]
sssd debug logs

Description of problem:
sssd forgets about the supportedControls retrieved from the rootDSE.


Version-Release number of selected component (if applicable):
sssd-1.5.1-34.el6.2.x86_64


How reproducible:
setup a ldap server with server-side password controls.


Steps to Reproduce:
1. setup 389-ds w/server-side pw controls
2. create an account and set the password
3. change the expiration date to within the expiration warning period
4. turn sssd debugging way up

  
Actual results:
see attached log


Expected results:
things like password expiration warnings should work


Additional info:
irc.freenode.net/#sssd:
<roysjosh> hello all.  I'm having some trouble with LDAP server-side password policy.  with debugging on, I get: [sdap_control_create] (3): Server does not support the requested control [1.3.6.1.4.1.42.2.27.8.5.1].  but a search of supportedControls on the rootDSE shows this control.  this means that I don't get warnings when passwords are about to expire, etc.
<roysjosh> and further debugging shows sssd getting that control: [sdap_set_rootdse_supported_lists] (1):  10 : 1.3.6.1.4.1.42.2.27.8.5.1
<roysjosh> sssd-1.5.1-34.el6.2, by the way
<roysjosh> also, for a possible future enhancement, 389-ds returns a control for expiration notification that sssd doesn't handle: [simple_bind_done] (9): Server returned control [2.16.840.1.113730.3.4.5].
<roysjosh> I don't think the supported controls are ever copied from the main connection to the binding connection...?
<roysjosh> I also have debugging in the loop in sdap_check_sup_list which doesn't print out anything
<sgallagh> sdap_connect_send() is *supposed* to re-request the RootDSE, I think.
<sgallagh> Let me check
<roysjosh> sdap_cli_connect_send does
<roysjosh> sgallagh, ^
<sgallagh> Ahh, ok.
<sgallagh> I see the problem, then.
<sgallagh> You're right, we should be either re-requesting the RootDSE or copying it from the original connection.
<sgallagh> roysjosh: Please file a Bugzilla with this information and we'll get it fixed.

Comment 4 Kaushik Banerjee 2011-09-20 16:06:25 UTC
Verified in version:

# rpm -qi sssd | head
Name        : sssd                         Relocations: (not relocatable)
Version     : 1.5.1                             Vendor: Red Hat, Inc.
Release     : 51.el6                        Build Date: Mon 12 Sep 2011 06:55:14 PM IST
Install Date: Tue 13 Sep 2011 08:02:21 PM IST      Build Host: x86-001.build.bos.redhat.com
Group       : Applications/System           Source RPM: sssd-1.5.1-51.el6.src.rpm
Size        : 3670464                          License: GPLv3+
Signature   : (none)
Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
URL         : http://fedorahosted.org/sssd/
Summary     : System Security Services Daemon

Comment 5 Jakub Hrozek 2011-10-27 15:29:10 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause: SSSD did not keep a copy of the list of supported LDAP controls during the whole LDAP operation. At the same time, it used the list of controls to determine if password expiration controls were available
Consequence: Password expiration warnings did not work because SSSD thought they were not available
Fix: SSSD always requests the expiration controls and only acts upon the controls actually being created or not.
Result: Password expiration warnings are displayed

Comment 6 errata-xmlrpc 2011-12-06 16:39:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1529.html