Bug 726441

Summary: Spice client waits for 30sec before connecting, when not using auto-conf or disable-effects
Product: Red Hat Enterprise Linux 6 Reporter: Arnon Gilboa <agilboa>
Component: spice-clientAssignee: Christophe Fergeau <cfergeau>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: high Docs Contact:
Priority: urgent    
Version: 6.2CC: acathrow, cfergeau, cmeadors, dblechte, mkenneth, mkrcmari, uril
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: All   
Whiteboard:
Fixed In Version: spice-client-0.8.2-2.el6 Doc Type: Bug Fix
Doc Text:
No documentation needed. The bug was filed during development (as a result of a fix for bug 712938), and never affected customers,
 Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 15:24:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
agent timeout patch none

Description Arnon Gilboa 2011-07-28 15:31:10 UTC 
Created attachment 515751 [details]
agent timeout patch

The (already pushed) patch from BZ #712938 comment 11 (https://bugzilla.redhat.com/show_bug.cgi?id=712938#c11) caused the following regression:

When client runs without the auto-conf or disable-effects options (either from CLI or controller), which is the case when using Spice from Admin Portal, the client will unecessarily wait for 30sec before connecting.

The mentioned patch assumed that on_agent_reply() of VD_AGENT_DISPLAY_CONFIG will call send_main_attach_channels() and connect. However, when auto-conf or disable-effects are not used, on_agent_reply() will ignore the reply and not call send_main_attach_channels(). Therefore, send_main_attach_channels() will only be called on agent timeout.

The solution is to activate agent timer only if auto-conf or disable-effects. Otherwise, simply call send_main_attach_channels(). Attached a proposed patch by Christophe.
Comment 3 Christophe Fergeau 2011-07-29 15:32:18 UTC 
This patch has been sent to the spice-devel mailing list for review.
Comment 8 Marian Krcmarik 2011-08-04 12:57:43 UTC 
Verified on spice-client-0.8.2-2/spice-client-msi-3.0-16 (ic136).
Comment 9 Uri Lublin 2011-11-21 10:14:04 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No documentation needed.

The bug was filed during development (as a result of a fix for bug 712938), and never affected customers,
Comment 10 errata-xmlrpc 2011-12-06 15:24:59 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1518.html