Bug 726474

Not-a-review, friendly feedback

It doesn't build, installed the dependencies and I've got:

[david@drlaptop SPECS]$ rpmbuild -ba quick-usb-formatter.spec 
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.Z6hxig
+ umask 022
+ cd /home/david/rpmbuild/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cd /home/david/rpmbuild/BUILD
+ rm -rf quick-usb-formatter-0.4
+ /usr/bin/gzip -dc /home/david/rpmbuild/SOURCES/quick-usb-formatter-0.4.tar.gz
+ /bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd quick-usb-formatter-0.4
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.YJ8eRQ
+ umask 022
+ cd /home/david/rpmbuild/BUILD
+ cd quick-usb-formatter-0.4
+ LANG=C
+ export LANG
+ unset DISPLAY
+ mkdir -p i686-redhat-linux-gnu
+ pushd i686-redhat-linux-gnu
~/rpmbuild/BUILD/quick-usb-formatter-0.4/i686-redhat-linux-gnu ~/rpmbuild/BUILD/quick-usb-formatter-0.4
+ QTDIR=/usr/lib/qt4
+ export QTDIR
+ PATH=/usr/lib/qt4/bin:/usr/lib/ccache:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/david/bin
+ export PATH
+ CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables'
+ export CFLAGS
+ CXXFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables'
+ export CXXFLAGS
+ FFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables'
+ export FFLAGS
+ '%{__cmake}' -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_BUILD_TYPE=release -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DDATA_INSTALL_DIR:PATH=/usr/share/kde4/apps -DINCLUDE_INSTALL_DIR:PATH=/usr/include/kde4 -DLIB_INSTALL_DIR:PATH=/usr/lib -DLIBEXEC_INSTALL_DIR:PATH=/usr/libexec/kde4 -DSYSCONF_INSTALL_DIR:PATH=/etc .. -DCMAKE_SHARED_LINKER_FLAGS=-Wl,--as-needed
/var/tmp/rpm-tmp.YJ8eRQ: line 41: fg: no job control
error: Bad exit status from /var/tmp/rpm-tmp.YJ8eRQ (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.YJ8eRQ (%build)
[david@drlaptop SPECS]$ 


Perhaps something missing in the build-requires?

(In reply to comment #1)
[snip]
> + '%{__cmake}' -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_BUILD_TYPE=release
> -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_VERBOSE_MAKEFILE=ON
> -DDATA_INSTALL_DIR:PATH=/usr/share/kde4/apps
> -DINCLUDE_INSTALL_DIR:PATH=/usr/include/kde4 -DLIB_INSTALL_DIR:PATH=/usr/lib
> -DLIBEXEC_INSTALL_DIR:PATH=/usr/libexec/kde4 -DSYSCONF_INSTALL_DIR:PATH=/etc ..
> -DCMAKE_SHARED_LINKER_FLAGS=-Wl,--as-needed
> /var/tmp/rpm-tmp.YJ8eRQ: line 41: fg: no job control
> error: Bad exit status from /var/tmp/rpm-tmp.YJ8eRQ (%build)
> 
> 
> RPM build errors:
>     Bad exit status from /var/tmp/rpm-tmp.YJ8eRQ (%build)
> [david@drlaptop SPECS]$ 
> 
> 
> Perhaps something missing in the build-requires?

%{__cmake} is not expanded -> BR on cmake would help here :)

Can you check in mock if it builds with our BR and add the one needed?

Here it fails with:
CMake Error at /usr/share/cmake/Modules/FindKDE4.cmake:98 (MESSAGE):
  ERROR: cmake/modules/FindKDE4Internal.cmake not found in
 --> Some KDE stuff still seems missing

Ok SPEC and SRPM has been updated with suggested changes and now mock is building rpm without errors

Spec URL: http://siddharths.fedorapeople.org/SPECS/quick-usb-formatter.spec
SRPM URL: http://siddharths.fedorapeople.org/SRPMS/quick-usb-formatter-0.4.1-2.fc16.src.rpm

Description: Quick Usb Formatter it is a tiny app designed for enhance the
usability of the device notifier plasmoid, an additional option for quick
format usb sticks

Review in progress expect results soon.

================================
Key:

[P] Pass
[F] Fail See [n]
[-] Not applicable
[?] Questions (see comments)

================================

[?]  MUST: rpmlint must be run on every package. The output should be
     posted in the review.

   quick-usb-formatter.i686: W: spelling-error %description -l en_US plasmoid
   -> plasmid, plasmodium, plasmosome
   quick-usb-formatter.i686: W: invalid-url URL: http://chakra-project.org
   /sources/quick-usb-formatter HTTP Error 404: Not Found
   quick-usb-formatter.i686: W: no-manual-page-for-binary quickusbformatter
   quick-usb-formatter.src: W: spelling-error %description -l en_US plasmoid
   -> plasmid, plasmodium, plasmosome
   quick-usb-formatter.src: W: invalid-url URL: http://chakra-project.org
   /sources/quick-usb-formatter HTTP Error 404: Not Found
   quick-usb-formatter-debuginfo.i686: W: invalid-url URL: http://chakra-
   project.org/sources/quick-usb-formatter HTTP Error 404: Not Found
   3 packages and 1 specfiles checked; 0 errors, 6 warnings.
   
    Spelling errors safe to ignore.

    No Manual page safe to ignore.
    
    404 on URL is valid. Is there no upstream site for this package?
    Perhaps it should be changed to http://chakra-project.org until
    upstream provides a page to avoid a 404?

[P]  MUST: The package must be named according to the Package Naming
     Guidelines.

[P]  MUST: The spec file name must match the base package %{name},
     in the format %{name}.spec unless your package has an exemption.

[P]  MUST: The package must meet the Packaging Guidelines.

[P]  MUST: The package must be licensed with a Fedora approved
     license and meet the Licensing Guidelines.

[?]  MUST: The License field in the package spec file must match
     the actual license.

     Source says LGPLv2.1 which is accepted per licensing rules, spec says
     GPLv3. Is there any reason for changing it?

[-]  MUST: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of
     the license(s) for the package must be included in %doc.

[P]  MUST: The spec file must be written in American English.

[P]  MUST: The spec file for the package MUST be legible.

[P]  MUST: The sources used to build the package must match the upstream
     source, as provided in the spec URL. Reviewers should use md5sum for
     this task. If no upstream URL can be specified for this package,
     please see the Source URL Guidelines for how to deal with this.

       fe724d8e4a392bb20caf245acb4bf9ad  quick-usb-formatter-0.4.1.tar.gz
       fe724d8e4a392bb20caf245acb4bf9ad  quick-usb-formatter-0.4.1.tar.gz(2)

[P]  MUST: The package MUST successfully compile and build into binary
     rpms on at least one primary architecture.

     Koji Build:
     http://koji.fedoraproject.org/koji/taskinfo?taskID=3482127

[-]  MUST: If the package does not successfully compile, build or work on
     an architecture, then those architectures should be listed in the spec
     in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug
     filed in bugzilla, describing the reason that the package does not
     compile/build/work on that architecture. The bug number MUST be
     placed in a comment, next to the corresponding ExcludeArch line.

[P]  MUST: All build dependencies must be listed in BuildRequires,
     except for any that are listed in the exceptions section of the
     Packaging Guidelines ; inclusion of those as BuildRequires is
     optional. Apply common sense.

[P]  MUST: The spec file MUST handle locales properly. This is done by
     using the %find_lang macro. Using %{_datadir}/locale/[ ] is strictly
     forbidden.

[-]  MUST: Every binary RPM package (or sub package) which stores shared
     library files (not just symlinks) in any of the dynamic linker's
     default paths, must call ldconfig in %post and %postun.

[-]  MUST: If the package is designed to be relocatable, the packager
     must state this fact in the request for review, along with the
     rationalization for relocation of that specific package.
     Without this, use of Prefix: /usr is considered a blocker.

[P]  MUST: A package must own all directories that it creates. If it does not
     create a directory that it uses, then it should require a package which
     does create that directory. Refer to the Guidelines for examples.

[P]  MUST: A package must not contain any duplicate files in the %files
     listing.

[P]  MUST: Permissions on files must be set properly. Executables should
     be set with executable permissions, for example. Every %files section
     must include a %defattr(...) line.

[-]  MUST: The %clean section is not required for F-13 and above. Each package
     for F-12 and below (or EPEL) MUST have a %clean section, which contains
     rm -rf %{buildroot} (or $RPM_BUILD_ROOT).

     F16+ Build
 
[P]  MUST: Each package must consistently use macros, as described in the
     macros section of Packaging Guidelines.

[P]  MUST: The package must contain code, or permissible content.
     This is described in detail in the code vs. content section
     of Packaging Guidelines.

[-]  MUST: Large documentation files should go in a -doc sub package.
     (The definition of large is left up to the packager's best judgement,
     but is not restricted to size. Large can refer to either size or quantity)

[P]  MUST: If a package includes something as %doc, it must not affect the
     runtime of the application. To summarize: If it is in %doc, the program
     must run properly if it is not present.

[-]  MUST: Header files must be in a -devel package.

[-]  MUST: Static libraries must be in a -static package.

[-]  MUST: Packages containing pkgconfig(.pc) files must 'Requires:
     pkgconfig' (for directory ownership and usability).

[-]  MUST: If a package contains library files with a suffix
     (e.g. libfoo.so.1.1), then library files that end in .so
     (without suffix) must go in a -devel package.

[-]  MUST: In the vast majority of cases, devel packages must require
     the base package using a fully versioned dependency: Requires:
     %{name} = %{version}-%{release}

[-]  MUST: Packages must NOT contain any .la libtool archives,
     these should be removed in the spec.

[P]  MUST: Packages containing GUI applications must include a
     %{name}.desktop file,and that file must be properly installed
     with desktop-file-install in the %install section. This is described
     in detail in the desktop files section of the Packaging Guidelines.
     If you feel that your packaged GUI application does not need a .desktop
     file, you must put a comment in the spec file with your explanation.

[P]  MUST: Packages must not own files or directories already owned by
     other packages. The rule of thumb here is that the first package
     to be installed should own the files or directories that other packages
     may rely upon. This means, for example, that no package in Fedora should
     ever share ownership with any of the files or directories owned by the
     file system or man package. If you feel that you have a good reason to
     own a file or directory that another package owns, then please present
     that at package review time.

[-]  MUST: At the beginning of %install, each package MUST run
     rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ). (For F12, EPEL Only)

      F16+ Build

[P]  MUST: All file names in rpm packages must be valid UTF-8.

SHOULD Items:

[P]  Should build in mock.
[P]  Should build on all supported archs
[-]  Should function as described.
[-]  Should have sane scriptlets.
[-]  Should have sub packages require base package with fully versioned depend.
[P]  Should have dist tag
[-]  Should package latest version (No upstream URL to verify)
[P]  Check for outstanding bugs on package. (For core merge reviews)

No real issues just a couple of questions.

Any progress here?

(In reply to comment #6)
> Any progress here?

yes, i reworked on it last saturday, would link up spec and srpm for testing

Ok SPEC and SRPM has been updated with suggested changes
building with Mock as well

Spec URL: http://siddharths.fedorapeople.org/SPECS/quick-usb-formatter.spec
SRPM URL: http://siddharths.fedorapeople.org/SRPMS/quick-usb-formatter-0.4.1-3.fc16.src.rpm

Description: Quick Usb Formatter it is a tiny app designed for enhance the
usability of the device notifier plasmoid, an additional option for quick
format usb sticks

quick-usb-formatter-debuginfo.i686: W: invalid-url URL: http://kde-apps.org/content/show.php?content=137493 <urlopen error [Errno -2] Name or service not known>
quick-usb-formatter.i686: W: invalid-url URL: http://kde-apps.org/content/show.php?content=137493 <urlopen error [Errno -2] Name or service not known>
quick-usb-formatter.i686: W: no-manual-page-for-binary quickusbformatter
quick-usb-formatter.src: W: invalid-url URL: http://kde-apps.org/content/show.php?content=137493 <urlopen error [Errno -2] Name or service not known>
quick-usb-formatter.src: W: strange-permission quick-usb-formatter-0.4.1.tar.gz 0600L
quick-usb-formatter.src: W: strange-permission quick-usb-formatter.spec 0600L
quick-usb-formatter.src: W: strange-permission desktop.patch 0600L
3 packages and 1 specfiles checked; 0 errors, 7 warnings.



False Positive on URL link works in browser.

Not sure why the other warnings are showing up they weren't in the previous tests.

(In reply to comment #9)
> quick-usb-formatter-debuginfo.i686: W: invalid-url URL:
> http://kde-apps.org/content/show.php?content=137493 <urlopen error [Errno -2]
> Name or service not known>
> quick-usb-formatter.i686: W: invalid-url URL:
> http://kde-apps.org/content/show.php?content=137493 <urlopen error [Errno -2]
> Name or service not known>
> quick-usb-formatter.i686: W: no-manual-page-for-binary quickusbformatter
> quick-usb-formatter.src: W: invalid-url URL:
> http://kde-apps.org/content/show.php?content=137493 <urlopen error [Errno -2]
> Name or service not known>
> quick-usb-formatter.src: W: strange-permission quick-usb-formatter-0.4.1.tar.gz
> 0600L
> quick-usb-formatter.src: W: strange-permission quick-usb-formatter.spec 0600L
> quick-usb-formatter.src: W: strange-permission desktop.patch 0600L
> 3 packages and 1 specfiles checked; 0 errors, 7 warnings.
> 
> 
> 
> False Positive on URL link works in browser.
> 
> Not sure why the other warnings are showing up they weren't in the previous
> tests.

I have updated spec and src rpm again Please recheck
Spec URL: http://siddharths.fedorapeople.org/SPECS/quick-usb-formatter.spec
SRPM URL: http://siddharths.fedorapeople.org/SRPMS/quick-usb-formatter-0.4.1-4.fc16.src.rpm

++Approved++

New Package SCM Request
=======================
Package Name:  quick-usb-formatter
Short Description: A small application to format usb sticks and devices
Owners: siddharths
Branches: f16
InitialCC:

Git done (by process-git-requests).

Added f17 branch.

done :)

(In reply to comment #14)
> done :)

Great :)

Rawhide build here:
http://koji.fedoraproject.org/koji/buildinfo?buildID=305954