Bug 727192

Summary: agent property uuid: Failed to open file '/etc/machine-id'
Product: Red Hat Enterprise Linux 6 Reporter: Dave Johnson <dajohnso>
Component: matahariAssignee: Andrew Beekhof <abeekhof>
Status: CLOSED ERRATA QA Contact: Dave Johnson <dajohnso>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.2CC: matahari-maint, rbryant, rrakus, whayutin
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: matahari-0.4.2-4.el6 Doc Type: Bug Fix
Doc Text:
No description required
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 11:39:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Dave Johnson 2011-08-01 13:58:50 UTC
Description of problem:
Query an agent and notice the uuid property is showing a file not found error

Version-Release number of selected component (if applicable):
[root@ibm-x3650-04 etc]# rpm -qa | egrep 'matahari|qpid' | sort
matahari-0.4.2-2.el6.x86_64
matahari-agent-lib-0.4.2-2.el6.x86_64
matahari-broker-0.4.2-2.el6.x86_64
matahari-devel-0.4.2-2.el6.x86_64
matahari-host-0.4.2-2.el6.x86_64
matahari-lib-0.4.2-2.el6.x86_64
matahari-network-0.4.2-2.el6.x86_64
matahari-service-0.4.2-2.el6.x86_64
matahari-sysconfig-0.4.2-2.el6.x86_64
python-qpid-0.10-1.el6.noarch
python-qpid-qmf-0.10-6.el6.x86_64
qpid-cpp-client-0.10-6.el6.x86_64
qpid-cpp-client-devel-0.10-6.el6.x86_64
qpid-cpp-client-ssl-0.10-6.el6.x86_64
qpid-cpp-server-0.10-6.el6.x86_64
qpid-cpp-server-ssl-0.10-6.el6.x86_64
qpid-qmf-0.10-6.el6.x86_64
qpid-qmf-devel-0.10-6.el6.x86_64
qpid-tools-0.10-3.el6.noarch
ruby-qpid-qmf-0.10-6.el6.x86_64


How reproducible:
100%

Steps to Reproduce:
1.  install 
2.  start daemons
3.  query agent properties with qmf-tool
  
Actual results:
file not found error for uuid property

Expected results:
valid uuid 

Additional info:
[root@ibm-x3650-04 etc]# qmf-tool localhost:49000
Management Tool for QMF
qmf: list agents
QMF Agents:
       Id  Vendor               Product  Instance                         Epoch
    ==========================================================================
    *  1   apache.org           qpidd    3f211c89-a503-424b-af63-a104d8c3c928  1
       2   matahariproject.org  Network  3bfacbdf-d105-48a8-b15f-3cf73bea6dc6  1
       3   matahariproject.org  host     cdc1d15d-b94b-4f53-a8d7-ac17191a6c75  1
       4   matahariproject.org  service  9bdc5314-faad-4db6-a416-e9a9559a8e0e  1
qmf: set default 2
Default Agent: matahariproject.org:Network:3bfacbdf-d105-48a8-b15f-3cf73bea6dc6
qmf: query Network org.matahariproject
Data Objects Returned: 1:
    Number  Data Address
    ==============================================
    1       9f05f21a-03f0-42e5-94f8-6f3a4bf633ef
qmf: show 1
Properties:
    Name      Value
    ============================================================================
    hostname  ibm-x3650-04.ovirt.rhts.eng.bos.redhat.com
    uuid      Failed to open file '/etc/machine-id': No such file or directory


qmf: set default 3
Default Agent: matahariproject.org:host:cdc1d15d-b94b-4f53-a8d7-ac17191a6c75
qmf: query Host org.matahariproject
Data Objects Returned: 1:
    Number  Data Address
    ==============================================
    2       e77de0a2-0e46-4fe0-a570-8fad7adb096e
qmf: show 2
Properties:
    Name                Value
  =========================================================================
    load       {'1': 0.0, '5': 0.02, '15': 0.02}
    hostname   ibm-x3650-04.ovirt.rhts.eng.bos.redhat.com
<snip>
    arch       x86_64
    uuid       Failed to open file '/etc/machine-id': No such file or directory


qmf: set default 4
Default Agent: matahariproject.org:service:9bdc5314-faad-4db6-a416-e9a9559a8e0e
qmf: query Services org.matahariproject
Data Objects Returned: 1:
    Number  Data Address
    ======================
    3       Services
qmf: show 3
Properties:
    Name      Value
    ============================================================================
    hostname  ibm-x3650-04.ovirt.rhts.eng.bos.redhat.com
    uuid      Failed to open file '/etc/machine-id': No such file or directory

Comment 1 Perry Myers 2011-08-01 14:23:38 UTC
ah

/etc/machine-id is part of systemd which doesn't exist in RHEL 6

This API needs to fall back to DBus uuid in /var/lib/dbus/machine-id if the former does not exist

Comment 2 Roman Rakus 2011-08-01 14:37:27 UTC
(In reply to comment #1)
> ah
> 
> /etc/machine-id is part of systemd which doesn't exist in RHEL 6
> 
> This API needs to fall back to DBus uuid in /var/lib/dbus/machine-id if the
> former does not exist

From my POV it's ok for our dbus* packages. But for qpid* it's not clear way.

Anyway it would be good to have some fallbacks. systemd -> dbus -> anything else? -> user friendly notification that uuid is not available. `Failed to open file '/etc/machine-id': No such file or directory' doesn't look good.

Comment 3 Perry Myers 2011-08-01 14:59:35 UTC
> From my POV it's ok for our dbus* packages. But for qpid* it's not clear way.
> 
> Anyway it would be good to have some fallbacks. systemd -> dbus -> anything
> else? -> user friendly notification that uuid is not available. `Failed to open
> file '/etc/machine-id': No such file or directory' doesn't look good.

@rrakus: I've been trying to have that exact conversation upstream.  Can you please see https://github.com/matahari/matahari/wiki/UUIDs and review the thread on matahari mailing list:
"Re: [Matahari] [Pcmk-cloud] /var/lib/dbus/machine_id, imagefactory, and matahari"

I sent out the above wiki url to list on Jul 27th but no one has chimed in yet

Comment 4 Andrew Beekhof 2011-08-09 00:15:08 UTC
A related patch has been committed:\n   https://github.com/beekhof/matahari/commit/cef7b38

Comment 6 Dave Johnson 2011-08-16 22:32:20 UTC
good 2 go in v0.4.2-6

Comment 7 Russell Bryant 2011-11-16 21:17:58 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No description required

Comment 8 errata-xmlrpc 2011-12-06 11:39:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1569.html