Bug 727477

Summary:	[webadmin] Dialog adjustments
Product:	[Retired] oVirt	Reporter:	Einav Cohen <ecohen>
Component:	ovirt-engine-webadmin	Assignee:	Tal Nisan <tnisan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	abaron, ecohen, iheim, vszocs, ykaul
Target Milestone:	m2
Target Release:	3.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	ux
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-09 07:58:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Einav Cohen 2011-08-02 08:57:37 UTC

- Oops dialog with Error: USER_IS_NOT_LOGGED_IN (not translated)
- closing that dialog just keeps appearing in a loop (probably because of the EventsListModel's timer).
- cannot copy the text from every dialog
- cannot use escape or enter to close the dialog
- it seems the dialog refreshes every 2 seconds, even if not closing it 
(trying to select the text in it, disappears)
- the error dialog cannot be dragged
- the dialog seems to be modal, though moving the mouse it changes cursor as 
if the tabs/logout button is working.

Comment 1 Vojtech Szocs 2011-08-02 14:43:08 UTC

> closing that dialog just keeps appearing in a loop (probably because of the
EventsListModel's timer).
this is right, it's because of FrontendFailureEventListener.eventRaised() called periodically (probably due to some timer)

For login section, the error popup re-appearing on top of itself (as well as consequent issues) should be already fixed:
commit 1761aef2627553cffdf3ea3a4b72dbdf6efab7fd
webadmin: Error popups disabled within login section

> the dialog seems to be modal, though moving the mouse it changes cursor as 
if the tabs/logout button is working.
this relates to styles: modal dialog creates an invisible "glass" element that fills the entire window area and prevents user interaction, however CSS styles (like :hover pseudo-class) still take effect

Following issues need to be implemented:
- cannot copy the text from every dialog
- cannot use escape or enter to close the dialog

Other issues should be fixed but need verification.

Comment 2 Einav Cohen 2011-10-09 14:15:35 UTC

It seems that the following issues are left:
- When dialog is opened, the main tabs still appear clickable
- cannot copy the text from every dialog
- cannot use escape or enter to close confirmation dialog (rest of the dialogs seem to work)

Comment 4 Vojtech Szocs 2011-10-21 14:44:46 UTC

> When dialog is opened, the main tabs still appear clickable

When dialog opens (GWTP PopupViewImpl#show method), by default it renders a "glass" div element that covers entire area behind the dialog. We can set CSS "cursor" property of this "glass" element so that any element behind it (e.g. main tab headers) will not appear clickable.

Simply, modify SimpleDialogPanel: getGlassElement().getStyle().setCursor(Cursor.DEFAULT)

Comment 7 Vojtech Szocs 2012-03-20 10:28:53 UTC

I went through the open issues, everything seems to be fixed by now, can somebody please verify?

Comment 8 Itamar Heim 2012-08-09 07:58:32 UTC

closing ON_QA bugs as oVirt 3.1 was released:
http://www.ovirt.org/get-ovirt/