Bug 728506
| Summary: | Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | Package Review | Assignee: | Bohuslav "Slavek" Kabrda <bkabrda> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkabrda, notting, package-review |
| Target Milestone: | --- | Flags: | bkabrda:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-09-30 16:54:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 705510 | ||
|
Description
Vít Ondruch
2011-08-05 11:50:28 UTC
* I would consider moving README.markdown into the main package, as it contains information about licensing, which I think should be present in the main package. * Moving VERSION file to doc subpackage results in error when trying to use the library (without doc subpackage installed): require 'i18n_data' Errno::ENOENT: No such file or directory - /usr/lib/ruby/gems/1.8/gems/i18n_data-0.2.7/lib/../VERSION from /usr/lib/ruby/gems/1.8/gems/i18n_data-0.2.7/lib/i18n_data.rb:2:in `read' (if you examine lib/i18_data.rb, you'll notice, that it tries to read the version from the VERSION file). So i recommend moving VERSION file into the main package. * I'd rethink including Requires: rubygem(activesupport), as the library works with file data provider by default, so the user doesn't necessarily need activesupport, which is only required by live data provider. My own recommendation is to remove this require. (In reply to comment #1) > * I would consider moving README.markdown into the main package, as it contains > information about licensing, which I think should be present in the main > package. DONE > * Moving VERSION file to doc subpackage results in error when trying to use the > library (without doc subpackage installed): > > require 'i18n_data' > Errno::ENOENT: No such file or directory - > /usr/lib/ruby/gems/1.8/gems/i18n_data-0.2.7/lib/../VERSION > from /usr/lib/ruby/gems/1.8/gems/i18n_data-0.2.7/lib/i18n_data.rb:2:in `read' > > (if you examine lib/i18_data.rb, you'll notice, that it tries to read the > version from the VERSION file). So i recommend moving VERSION file into the > main package. Good spot! Thank you. > * I'd rethink including Requires: rubygem(activesupport), as the library works > with file data provider by default, so the user doesn't necessarily need > activesupport, which is only required by live data provider. My own > recommendation is to remove this require. You are right. Less requires is better. Spec URL: http://people.redhat.com/vondruch/rubygem-i18n_data.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-i18n_data-0.2.7-2.fcf17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3372233 Everything looks fine now, this package is APPROVED. New Package SCM Request ======================= Package Name: rubygem-i18n_data Short Description: Country/language names and 2-letter-code pairs, in 85 languages Owners: vondruch Branches: InitialCC: Git done (by process-git-requests). |