Bug 728691

*** Bug 526100 has been marked as a duplicate of this bug. ***

I will do the review

I see, you have taken the SPEC file from https://bugzilla.redhat.com/show_bug.cgi?id=526100 , It would be nice to credit the original author in the Changelog section

ok sure, done. Didn't bump the release.
Spec URL:
http://kumarpraveen.fedorapeople.org/registration/django-registration.spec
SRPM URL:
http://kumarpraveen.fedorapeople.org/registration/django-registration-0.7-1.fc15.src.rpm

You can't have two changelog entries with the same release number.  Bump up the release everytime you do the change.  Always

ok, Thanks for pointing out.

Spec URL:
http://kumarpraveen.fedorapeople.org/registration/django-registration.spec
SRPM URL: http://kumarpraveen.fedorapeople.org/registration/django-registration-0.7-2.fc15.src.rpm

koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3256202

I have done the review, I found two issues with the package,

1. The latest version is 0.8-alpha1, do we have to update to the latest version?

2. The package includes locale files , do we have to add gettext to buildrequires?

(In reply to comment #7)
> I have done the review, I found two issues with the package,
> 
> 1. The latest version is 0.8-alpha1, do we have to update to the latest
> version?

I asked to rahul, he said right now we have to go for 0.7, when upstream relase of a stable of 0.8 then we will update it.

> 2. The package includes locale files , do we have to add gettext to
> buildrequires?
I will add this if it is really need because during koji build didn't show any build requires.

complete review:

+ = OK
- = NA
? = issue


+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.

+ Sources match upstream md5sum:
5c92e93a699905dce2e3f59285013b0a  django-registration-0.7.tar.gz
5c92e93a699905dce2e3f59285013b0a  django-registration-0.7.tar.gz


- Package needs ExcludeArch
+ BuildRequires correct
+ Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package is code or permissible content.
+ Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
http://koji.fedoraproject.org/koji/taskinfo?taskID=3270799

+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output. 
(warning can be ignored)
[zer0c00l@gnubox noarch]$ rpmlint django-registration-0.7-2.fc15.noarch.rpm 
django-registration.noarch: W: spelling-error %description -l en_US signups -> sign ups, sign-ups, signposts
1 packages and 0 specfiles checked; 0 errors, 1 warning


- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and
anything provided by glibc.)

SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
+ Should function as described.
Tested the application it works as described
+ Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
? Should package latest version
https://bitbucket.org/ubernostrum/django-registration/downloads 
The latest version is 0.8-alpha-1 should we package it?

- check for outstanding bugs on package. (For core merge reviews

XXXXXXXXXXXX APPROVED XXXXXXXXXXXXXXXXXX

We will ship 0.7 version of django-registration

New Package SCM Request
=======================
Package Name: django-registration
Short Description: A user-registration application for Django
Owners: sundaram pjp kumarpraveen
Branches: f14 f15 f16 el6

Git done (by process-git-requests).

I just stumbled upon this and could really use it. Any progress here? May I help you?

Praveen, ping.

(In reply to comment #13)
> Praveen, ping.

Please forget this comment. I must have missed pkgb emails.