Bug 728823
| Summary: | Review Request: django-tinymce - TinyMCE form field editor for Django applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yuguang Wang <yuwang> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, panemade, petersen, rhe, vchen |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-04 05:08:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 690728 | ||
|
Description
Yuguang Wang
2011-08-08 02:36:03 UTC
rpmlint results: $ rpmlint django-tinymce-1.5-1.fc13.src.rpm django-tinymce.src: W: file-size-mismatch django-tinymce-1.5.tar.gz = 13732, http://django-tinymce.googlecode.com/files/django-tinymce-1.5.tar.gz = 13396 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint django-tinymce.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Warning becoz the package from googlecode has no spec files in it, I created a spec file for it. (In reply to comment #1) > rpmlint results: > > $ rpmlint django-tinymce-1.5-1.fc13.src.rpm > django-tinymce.src: W: file-size-mismatch django-tinymce-1.5.tar.gz = 13732, > http://django-tinymce.googlecode.com/files/django-tinymce-1.5.tar.gz = 13396 > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > > $ rpmlint django-tinymce.spec > 0 packages and 1 specfiles checked; 0 errors, 0 warnings. (In reply to comment #2) > Warning becoz the package from googlecode has no spec files in it, I created a > spec file for it. Erm that is normal. :) > (In reply to comment #1) > > rpmlint results: > > > > $ rpmlint django-tinymce-1.5-1.fc13.src.rpm > > django-tinymce.src: W: file-size-mismatch django-tinymce-1.5.tar.gz = 13732, > > http://django-tinymce.googlecode.com/files/django-tinymce-1.5.tar.gz = 13396 > > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Please don't do that. There is no need to re-roll the upstream tarball. ping? hi Jens, What do you mean by 'There is no need to re-roll the upstream tarball'? Shouldn't I provide the src.rpm? Did I miss anything? You modified the tarball in the srpm, right? You should just use the upstream source file without any modification. The srpm already includes the spec file automatically there is no need whatsoever to include it in the tarball. Hope that makes it clearer. :) (In reply to comment #6) Gotcha, thanks. srpm updated with spec file removed: http://yuwang.fedorapeople.org/django-tinymce.spec http://yuwang.fedorapeople.org/django-tinymce-1.5-1.fc13.src.rpm > You modified the tarball in the srpm, right? > You should just use the upstream source file without any modification. > The srpm already includes the spec file automatically there > is no need whatsoever to include it in the tarball. > Hope that makes it clearer. :) Every modification to SPEC file should bump the release tag and add a appropriate changelog. I see tarball checksum is still not matching. a181255e8efe7b57a22851ebb184f3b9bf867bac django-tinymce-1.5.tar.gz 9830507cd89f5cc3abea0fedea4a4cf9fbdeeb59 ../SOURCES/django-tinymce-1.5.tar.gz *** Always use the upstream source tarball and if required patch it in SPEC *** (In reply to comment #8) Thanks for informing, I used the original tarball to build srpm. I guess it's ok now, version/release bumped to 1.5-2: http://yuwang.fedorapeople.org/django-tinymce.spec http://yuwang.fedorapeople.org/django-tinymce-1.5-2.fc13.src.rpm > Every modification to SPEC file should bump the release tag and add a > appropriate changelog. I see tarball checksum is still not matching. Review: + koji scratch build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3545280 + rpmlint on rpms gave django-tinymce.src: W: invalid-url Source0: http://django-tinymce.googlecode.com/files/django-tinymce-1.5.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 1 warnings. ==> This looks a false message. + source verified with upstream as (sha1sum) a181255e8efe7b57a22851ebb184f3b9bf867bac django-tinymce-1.5.tar.gz a181255e8efe7b57a22851ebb184f3b9bf867bac ../SOURCES/django-tinymce-1.5.tar.gz + rest follows packaging guidelines. Suggestions: 1) Remove CFLAGS="$RPM_OPT_FLAGS" from %build as this is noarch package APPROVED. Can you request the fedora-cvs flag and do you need the sponsorship? (In reply to comment #11) > Can you request the fedora-cvs flag I cannot mark the flag 'fedora‑cvs' for this bug, not clickable. >do you need the sponsorship? I guess so. And thanks for the update. Ok. I have sponsored you now. You can try now or after some time for fedora-cvs flag. yuwang, Please go through http://fedoraproject.org/wiki/New_package_process_for_existing_contributors page. Now you are at step 7. you need to raise fedora-cvs-? flag and the dist-git admins will create a git package module for you and they will change it to fedora-cvs+ Please include an SCM request. ping New Package SCM Request ======================= Package Name: django-tinymce Short Description: TinyMCE form field editor for Django applications Owners: yuwang Branches: f15 f16 el6 InitialCC: yuwang yuwang, Looks like you missed to raise a fedora-cvs flag. I have done it for you. Thanks :) Git done (by process-git-requests). koji build successfully(el6): Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=3617691 Thanks all for your help, close it as NEXTREALEASE. |