| Summary: | Review Request: wadofstuff-django-serializers - Extended Django Serializer Module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yuguang Wang <yuwang> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dli, notting, package-review, panemade, petersen, rhe, vchen, yuwang |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-23 09:54:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 690728 | ||
|
Description
Yuguang Wang
2011-08-08 03:22:46 UTC
[yuwang@yuwang wadofstuff-django-serializers-1.1.0]$ rpmlint wadofstuff-django-serializers.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Could you please post an srpm? You need to include the release number in changelog entries: wadofstuff-django-serializers.noarch: W: incoherent-version-in-changelog 1.1.0 ['1.1.0-1.fc15', '1.1.0-1'] Wow, warning not allowed. Spec file updated: http://yuwang.fedorapeople.org/wadofstuff-django-serializers.spec rpmlint ok: [yuwang@yuwang wadofstuff-django-serializers-1.1.0]$ rpmlint wadofstuff-django-serializers-1.1.0-1.fc13.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. (In reply to comment #2) > Could you please post an srpm? > > You need to include the release number in changelog entries: > > wadofstuff-django-serializers.noarch: W: incoherent-version-in-changelog 1.1.0 > ['1.1.0-1.fc15', '1.1.0-1'] Thanks and where is the srpm? Uploaded in fedorapeople, rpm built in fedora 13: http://yuwang.fedorapeople.org/wadofstuff-django-serializers-1.1.0-1.fc13.src.rpm Thanks - as I mentioned also in bug 728823 please don't repackage the source tarball. We don't do that in Fedora, but always ship pristine source (which can be patched via rpm if necessary.) Adding the .spec is also kind of meaningless since it is already in the src.rpm anyway and will change each time you update the package. ping? Package updated: http://yuwang.fedorapeople.org/wadofstuff-django-serializers.spec http://yuwang.fedorapeople.org/wadofstuff-django-serializers-1.1.0-1.fc13.src.rpm rpmlint wadofstuff-django-serializers-1.1.0-1.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Review: + koji scratch build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3528874 + rpmlint on rpms gave wadofstuff-django-serializers.noarch: W: install-file-in-docs /usr/share/doc/wadofstuff-django-serializers-1.1.0/INSTALL 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + source match with upstream as (sha1sum) cef278159d28d235b4eb06bc4b7864b9d9a8a9ed wadofstuff-django-serializers-1.1.0.tar.gz cef278159d28d235b4eb06bc4b7864b9d9a8a9ed ../SOURCES/wadofstuff-django-serializers-1.1.0.tar.gz + Follows packaging guidelines. suggestions: 1) we don't recommend to add INSTALL file as its only for manually installation from tarball. so remove that from spec. APPROVED. Can you request for SCM? New Package SCM Request ======================= Package Name: wadofstuff-django-serializers Short Description: Extended Django Serializer Module Owners: yuwang Branches: f15 f16 el6 InitialCC: yuwang Git done (by process-git-requests). Koji build successfully. F16: https://koji.fedoraproject.org/koji/taskinfo?taskID=3602719 el6: http://koji.fedoraproject.org/koji/taskinfo?taskID=3602733 Thanks all for your help. |