Bug 728854

Summary: Save notification closes the editor unnecessarily
Product: [Retired] Zanata Reporter: Sean Flanigan <sflaniga>
Component: Component-UIAssignee: Alex Eng <aeng>
Status: CLOSED CURRENTRELEASE QA Contact: Ding-Yi Chen <dchen>
Severity: high Docs Contact:
Priority: high    
Version: 1.3CC: aeng, damason, zanata-bugs
Target Milestone: ---   
Target Release: 1.4.2   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-28 07:02:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 746870    

Description Sean Flanigan 2011-08-08 07:08:40 UTC 
User-Agent:       Mozilla/5.0 (X11; Linux i686 (x86_64)) AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.100 Safari/534.30

The user's own save notifications can cause the editor to close (cancel edit).  

This problem can happen when clicking up and down in the table, depending on processing speed, but the most consistent trigger is based on key shortcuts.

Reproducible: Always

Steps to Reproduce:
1. Enter some text in a target cell (ie change the content) to force a Save upon exit.
2. Press Alt+J+K (ie Alt+J and Alt+K virtually simultaneusly).
Actual Results:  
Cell content saved, but the save notification for that cell causes the editor to close.  If the notification is for the text content as is currently in the editor, there is no need to cancel editing.

Expected Results:  
Cell content saved; editor is open on the original target cell.
Comment 1 Sean Flanigan 2011-08-08 07:17:12 UTC 
Note that this problem is currently exacerbated by bug 728858's extra save notifications.
Comment 2 David Mason 2011-08-08 07:19:49 UTC 
This bug is probably related to bug 728851
Comment 3 Sean Flanigan 2011-08-10 05:37:13 UTC 
If we fix bug 728858, I suppose this one won't need a high priority.
Comment 4 Sean Flanigan 2011-09-07 04:33:20 UTC 
Assigning to Scrum product owner for prioritisation.
Comment 5 Runa Bhattacharjee 2011-09-08 13:15:09 UTC 
This is a serious loss of functionality of the editor. Moving this back to high.
Comment 6 Alex Eng 2011-10-20 00:34:28 UTC 
Problem fixed along with fixes in https://bugzilla.redhat.com/show_bug.cgi?id=746870.
See https://github.com/zanata/zanata/commit/0085dc7482aed3e1a9d7a8b6b6464059a81a86f3
Comment 7 Ding-Yi Chen 2011-10-20 04:25:03 UTC 
VERIFIED with Zanata version 1.4.2-SNAPSHOT (20111020-1402)