Bug 728889

Created attachment 517162 [details]
remove the buggy fix

remove overloading of Date.toLocaleFormat

Created attachment 517356 [details]
remove locale formats not supported by glib

glib does not support locale's alternative numeric symbols like %OI %OM

Related issue: when using

LANG="nb_NO.ISO-8859-1"

in /etc/sysconfig/i180n

the overloading breaks gnome-shell. Now I have lots of broken desktops...

This is with Fedora 16, all updates.

Might be that the special ø, included in Sat (Lør) and Sun (Søn), that breaks
gnome-shell. So systems are in non working state during weekends :-)

Please fix asap as this breaks people desktops.

Error msg is:

gnome-session[2504]: DEBUG(+): GsmDBusClient: obj_path=/org/gnome/SessionManager/Presence interface=org.freedesktop.DBus.Properties method=GetAl
l
    JS ERROR: !!!   Exception was: Error: Failed to convert UTF-8 string to JS string: Ugyldig bytesekvens i inndata for konvertering
    JS ERROR: !!!     lineNumber = '0'
    JS ERROR: !!!     fileName = '"gjs_throw"'
    JS ERROR: !!!     stack = '"("Failed to convert UTF-8 string to JS string: Ugyldig bytesekvens i inndata for konvertering")@gjs_throw:0
("%a %R")@/usr/share/gnome-shell/js/ui/environment.js:75()@/usr/share/gnome-shell/js/ui/dateMenu.js:208
([object Object])@/usr/share/gnome-shell/js/ui/dateMenu.js:167
DateMenuButton([object Object])@/usr/share/gnome-shell/js/ui/dateMenu.js:44
()@/usr/share/gnome-shell/js/ui/panel.js:950
Panel()@/usr/share/gnome-shell/js/ui/panel.js:887
start()@/usr/share/gnome-shell/js/ui/main.js:213
@<main>:1
"'
    JS ERROR: !!!     message = '"Failed to convert UTF-8 string to JS string: Ugyldig bytesekvens i inndata for konvertering"'Advarsel fra vindush?ndterer: Log level 32: Execution of main.js threw exception: Error: Failed to convert UTF-8 string to JS string: Ugyldig bytesekvens i inndata for konvertering

(In reply to comment #3)
> Related issue: when using

Actually, not a related issue.

> LANG="nb_NO.ISO-8859-1"

This is not a supported or supportable configuration. Only UTF-8 locales are supported in Fedora.
 
> in /etc/sysconfig/i180n
> 
> the overloading breaks gnome-shell. Now I have lots of broken desktops...
> 
> This is with Fedora 16, all updates.
> 
> Might be that the special ø, included in Sat (Lør) and Sun (Søn), that breaks
> gnome-shell. So systems are in non working state during weekends :-)
> 
> Please fix asap as this breaks people desktops.

This particular issue is likely fixable, and I'd commit a patch for it if a correct patch was provided upstream, but I'm not intending to investigate or come up with a fix myself.

> Actually, not a related issue.

Okay, so when things works when the overloading hack is removed is pure luck?

> > LANG="nb_NO.ISO-8859-1"
> 
> This is not a supported or supportable configuration. Only UTF-8 locales are
> supported in Fedora.

This locale has been used on RHL, RHEL and Fedora since 1998 (and is included in "locale -a" output in Fedora 16), could you please provide a document which
describe the transition to UTF-8 as only supported encoding?


> > Please fix asap as this breaks people desktops.
> 
> This particular issue is likely fixable, and I'd commit a patch for it if a
> correct patch was provided upstream, but I'm not intending to investigate or
> come up with a fix myself.

Sorry for noise, mea culpa.

(In reply to comment #5)
> > Actually, not a related issue.
> 
> Okay, so when things works when the overloading hack is removed is pure luck?

The problem may occur in the same portion of the code and the same workaround may work, but this particular bug is about something very specific - the lack of support in GLib for particular time format specifiers - which was resolved in GLib 2.30 (you can follow the upstream bug link to https://bugzilla.gnome.org/show_bug.cgi?id=656196), so this bug in fact should be closed CURRENTRELEASE.

> > > LANG="nb_NO.ISO-8859-1"
> > 
> > This is not a supported or supportable configuration. Only UTF-8 locales are
> > supported in Fedora.
> 
> This locale has been used on RHL, RHEL and Fedora since 1998 (and is included
> in "locale -a" output in Fedora 16), could you please provide a document which
> describe the transition to UTF-8 as only supported encoding?

I did the work to switch the GNOME desktop over to UTF-8 internally in the time period 1999-2002.

The situation where the internals of GNOME are UTF-8 but the system encoding only supports a tiny 256 character subset is essentially broken - e.g. what do you do if the user enters a filename that you can't save to disk?

I did write some compatibility code, but there's been basically no testing of that code, and I don't see at all reasonable to add more testing and try to fix that code up when we really want to just get users to make the move.

(In a quick look, I can't spot the problem here, but it's likely in code in GLib that was added just a few years ago, so much later than the general translations.)