Bug 729263
Summary: | Review Request: rubygem-virt-p2v - Send a machine's storage and metadata to virt-p2v-server | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matthew Booth <mbooth> |
Component: | Package Review | Assignee: | Richard W.M. Jones <rjones> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, rjones, vondruch |
Target Milestone: | --- | Flags: | rjones:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-05-11 08:11:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Matthew Booth
2011-08-09 09:57:20 UTC
Taking for review ... Koji scratch build for F16 was successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=3282218 This package is ExclusiveArch: i686 (for perfectly good reasons). However this means I could not build it on my local machine. Therefore all testing was done using the packages built in Koji. - rpmlint output No %changelog section in the spec file. Multiple instances of 'incorrect-fsf-address' in the source. I will submit a patch upstream to fix this. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines %defattr lines are not strictly required, but can be left in for EPEL compatibility. BuildRoot is no longer needed, but can be left in for EPEL compat. + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm + package successfully builds on at least one architecture (only on i686) n/a ExcludeArch bugs filed + BuildRequires list all build dependencies (because of Koji scratch build) n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + consistent use of macros + package must contain code or permissible content + large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file Although this is a "GUI app" it is not a desktop app. It boots from an ISO on a separate machine, so no desktop file is required. + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock + the package should build into binary RPMs on all supported architectures + review should test the package functions as described n/a scriptlets should be sane n/a pkgconfig files should go in -devel n/a shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin ------------- The package has a couple of errors which are very simple to fix, so I'll just go ahead and submit fixes on behalf of the packager. Updated spec file includes a changelog section: http://oirase.annexia.org/reviews/rubygem-virt-p2v.spec I have pushed a patch upstream which updates the FSF addresses in all comments and documentation: http://git.fedorahosted.org/git/?p=virt-v2v.git;a=commitdiff;h=2b4d755b3e1f249f2a7631e1450f5b225c31761e ----- Therefore this package is APPROVED by rjones. New Package SCM Request ======================= Package Name: rubygem-virt-p2v Short Description: Send a machine's storage and metadata to virt-p2v-server Owners: mdbooth rwmjones Branches: f14 f15 f16 InitialCC: mdbooth Richard, please take ownership of the bug, and correct your FAS username in the request. Thanks! New Package SCM Request ======================= Package Name: rubygem-virt-p2v Short Description: Send a machine's storage and metadata to virt-p2v-server Owners: mdbooth rjones Branches: f14 f15 f16 InitialCC: Git done (by process-git-requests). Seems to be already in Fedora. I'm closing this bug. |