Bug 729289
Summary: | CLI: when scheduling an operation, no error is returned if an invalid operation name is specified | ||
---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | Ondřej Žižka <ozizka> |
Component: | CLI | Assignee: | Ian Springer <ian.springer> |
Status: | CLOSED NOTABUG | QA Contact: | Mike Foley <mfoley> |
Severity: | low | Docs Contact: | |
Priority: | medium | ||
Version: | 3.0.1 | CC: | ccrouch, hrupp, ian.springer |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-08-10 19:10:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 678340, 725459 |
Description
Ondřej Žižka
2011-08-09 11:34:53 UTC
Is it "shutdown"? Why didn't it throw an exception then. And, "start" did not either. Yes, it's "shutdown". Here are the ops defined in the plugin descriptor: <operation name="start" displayName="Start" description="Start this application server. The script used is specified in the Operations group of connection properties. This operation will fail if the server is already started."> <results><c:simple-property name="operationResult" description="Outcome of starting the server."/></results> </operation> <operation name="shutdown" displayName="Shut Down" description="Shut down this application server via script or JMX, depending on the settings in the Operations and Advanced groups of connection properties. This operation will fail if the server is already shut down."> <results><c:simple-property name="operationResult" description="Outcome of shutting down the server."/></results> </operation> <operation name="restart" displayName="Restart" description="Shut down (if started) and then start this application server."> <results><c:simple-property name="operationResult" description="Outcome of restarting the server."/></results> </operation> I agree. it should have thrown an "Unknown operation 'stop'." exception. scheduleResourceOperation() and scheduleGroupOperation() now validate that the specified operation name and parameters are valid for the specified Resource. If not, they throw an IllegalArgumentException - [master f8c0c68]. Thx, that will help. Setting priority to low since it turned to be an ID-10-T error (I copied a script from somewhere without checking rhq-plugin.xml). Can be closed, as far as I am concerned. closing, per bug loggers ID-10-T comment (user error) |